Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 2459873002: Revert of Replace FileWrapper with File (in audio_device) (Closed)

Created:
4 years, 1 month ago by terelius
Modified:
4 years, 1 month ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, audio-team_agora.io, sdk-team_agora.io, peah-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Replace FileWrapper with File (in audio_device) (patchset #3 id:40001 of https://codereview.webrtc.org/2386963003/ ) Reason for revert: Speculative revert. This CL is a plausible cause for breakages in internal projects. Original issue's description: > Removes all uses of FileWrapper in audio_device. > > BUG=webrtc:6463 > > Committed: https://crrev.com/04055e95bf97d106053d90bcc9e974eb4ad175e6 > Cr-Commit-Position: refs/heads/master@{#14811} TBR=sprang@webrtc.org,henrika@webrtc.org,palmkvist@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6463 Committed: https://crrev.com/c4b9b9419e441e188e4999415b84b1876639a322 Cr-Commit-Position: refs/heads/master@{#14822}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -96 lines) Patch
M webrtc/modules/audio_device/audio_device_buffer.h View 2 chunks +2 lines, -1 line 0 comments Download
M webrtc/modules/audio_device/dummy/file_audio_device.h View 4 chunks +7 lines, -6 lines 0 comments Download
M webrtc/modules/audio_device/dummy/file_audio_device.cc View 7 chunks +95 lines, -89 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
terelius
Created Revert of Replace FileWrapper with File (in audio_device)
4 years, 1 month ago (2016-10-28 13:51:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2459873002/1
4 years, 1 month ago (2016-10-28 13:51:55 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-28 13:52:02 UTC) #4
commit-bot: I haz the power
4 years, 1 month ago (2016-10-28 13:52:14 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c4b9b9419e441e188e4999415b84b1876639a322
Cr-Commit-Position: refs/heads/master@{#14822}

Powered by Google App Engine
This is Rietveld 408576698