Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(516)

Unified Diff: webrtc/modules/congestion_controller/probe_controller_unittest.cc

Issue 2458863002: Start probes only after network is connected. (Closed)
Patch Set: sync Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/modules/congestion_controller/probe_controller.cc ('k') | webrtc/test/call_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/modules/congestion_controller/probe_controller_unittest.cc
diff --git a/webrtc/modules/congestion_controller/probe_controller_unittest.cc b/webrtc/modules/congestion_controller/probe_controller_unittest.cc
index 98e116644ca714c9c17ceb21f64663246746a143..3842ded5a6909eb61caffdca2cce69a1f4f5d669 100644
--- a/webrtc/modules/congestion_controller/probe_controller_unittest.cc
+++ b/webrtc/modules/congestion_controller/probe_controller_unittest.cc
@@ -51,6 +51,17 @@ TEST_F(ProbeControllerTest, InitiatesProbingAtStart) {
kMaxBitrateBps);
}
+TEST_F(ProbeControllerTest, ProbeOnlyWhenNetworkIsUp) {
+ probe_controller_->OnNetworkStateChanged(kNetworkDown);
+ EXPECT_CALL(pacer_, CreateProbeCluster(_, _)).Times(0);
+ probe_controller_->SetBitrates(kMinBitrateBps, kStartBitrateBps,
+ kMaxBitrateBps);
+
+ testing::Mock::VerifyAndClearExpectations(&pacer_);
+ EXPECT_CALL(pacer_, CreateProbeCluster(_, _)).Times(AtLeast(2));
+ probe_controller_->OnNetworkStateChanged(kNetworkUp);
+}
+
TEST_F(ProbeControllerTest, InitiatesProbingOnMaxBitrateIncrease) {
EXPECT_CALL(pacer_, CreateProbeCluster(_, _)).Times(AtLeast(2));
probe_controller_->SetBitrates(kMinBitrateBps, kStartBitrateBps,
« no previous file with comments | « webrtc/modules/congestion_controller/probe_controller.cc ('k') | webrtc/test/call_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698