Start probes only after network is connected.

webrtc/call/call.cc

Index: webrtc/call/call.cc
diff --git a/webrtc/call/call.cc b/webrtc/call/call.cc
index d7272170841c665883fff1e4ceae0adb1e12d66b..a5b3e067678152e3b0968e7aba1696a3582da4fc 100644
--- a/webrtc/call/call.cc
+++ b/webrtc/call/call.cc
@@ -249,8 +249,8 @@ Call::Call(const Call::Config& config)
       call_stats_(new CallStats(clock_)),
       bitrate_allocator_(new BitrateAllocator(this)),
       config_(config),
-      audio_network_state_(kNetworkUp),
-      video_network_state_(kNetworkUp),
+      audio_network_state_(kNetworkDown),
+      video_network_state_(kNetworkDown),
       receive_crit_(RWLockWrapper::CreateRWLock()),
       send_crit_(RWLockWrapper::CreateRWLock()),
       event_log_(config.event_log),
@@ -281,6 +281,7 @@ Call::Call(const Call::Config& config)
   Trace::CreateTrace();
   call_stats_->RegisterStatsObserver(congestion_controller_.get());
 
+  congestion_controller_->SignalNetworkState(kNetworkDown);
   congestion_controller_->SetBweBitrates(
       config_.bitrate_config.min_bitrate_bps,
       config_.bitrate_config.start_bitrate_bps,
@@ -695,9 +696,10 @@ void Call::SetBitrateConfig(
   if (bitrate_config.start_bitrate_bps > 0)
     config_.bitrate_config.start_bitrate_bps = bitrate_config.start_bitrate_bps;
   config_.bitrate_config.max_bitrate_bps = bitrate_config.max_bitrate_bps;
-  congestion_controller_->SetBweBitrates(bitrate_config.min_bitrate_bps,
-                                         bitrate_config.start_bitrate_bps,
-                                         bitrate_config.max_bitrate_bps);
+  congestion_controller_->SetBweBitrates(
+      config_.bitrate_config.min_bitrate_bps,
+      config_.bitrate_config.start_bitrate_bps,

[stefan-webrtc, 2016/11/09 18:07:55]

Is this a change in behavior? Did we perhaps previously sometimes call with 0
here to indicate that we didn't want to restart a new start bitrate, but simply
update the min and max?

I think that is what the comment on line 694-695 is saying.

[Sergey Ulanov, 2016/11/09 18:34:12]

Reverted this code back to what it was and added back the check for
start_bitrate_bps > 0 in ProbeController::SetBitrates(). It doesn't look right
the parameter called start_bitrate_bps actually changes current bitrate. Maybe
it shouldn't be called start_bitrate_bps? Or maybe SetBweBitrate() should be
updated to use that parameter only to initialize bitrate when we don't have a BW
estimate?
The problem seems to be in BitrateControllerImpl::SetBitrates(): it uses
parameter start_bitrate_bps to reset current bitrate (note that there is also
ResetBitrates() which actually resets bitrates).

+      config_.bitrate_config.max_bitrate_bps);
 }
 
 void Call::SignalChannelNetworkState(MediaType media, NetworkState state) {