Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1523)

Issue 2458363002: Reland Change ViEEncoder to not reconfigure the encoder until the video resolution is known. (Closed)

Created:
4 years, 1 month ago by perkj_webrtc
Modified:
4 years, 1 month ago
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, the sun, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland Change ViEEncoder to not reconfigure the encoder until the video resolution is known. This is the second reland. Patchset 1 contains the reverted cl. Patchset 2 revert the change to initialize the encoder with resolution 1*1pixels if an internal source is used. This is to to fix the problem reported in https://codereview.webrtc.org/2457203002/ https://build.chromium.org/p/chromium.webrtc.fyi/builders/Mac%20Tester/builds/35251 remoting. Fix has been verified to work in Chrome. This reverts commit 05a55b500d83e4212d4e54f0fecf13097e782ffa. BUG=webrtc:6371 b/32285861 TBR=pbos@webrtc.org, skvlad@webrtc.org, stefan@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/21d45d2ab63109d75bfd52dc0cd53877ef432cf0

Patch Set 1 #

Patch Set 2 : Revert to VideoFrameInfo(176, 144, kVideoRotation_0, false). #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -65 lines) Patch
M webrtc/call/call_perf_tests.cc View 3 chunks +9 lines, -6 lines 0 comments Download
M webrtc/media/engine/webrtcvideoengine2_unittest.cc View 2 chunks +12 lines, -8 lines 0 comments Download
M webrtc/video/video_send_stream_tests.cc View 11 chunks +17 lines, -32 lines 0 comments Download
M webrtc/video/vie_encoder.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video/vie_encoder.cc View 1 2 chunks +9 lines, -10 lines 0 comments Download
M webrtc/video/vie_encoder_unittest.cc View 4 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (5 generated)
perkj_webrtc
4 years, 1 month ago (2016-10-30 20:36:02 UTC) #2
perkj_webrtc
4 years, 1 month ago (2016-10-30 20:39:02 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
21d45d2ab63109d75bfd52dc0cd53877ef432cf0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698