Style cleanups in rtp header extension traits:

Style cleanups in rtp header extension traits:
renamed kName to kUri and make it more const.
remove IsSupportedBy to reduce header dependency.

BUG=webrtc:1994
Committed: https://crrev.com/e2a017725570ead5946a4ca8235af27470ca0df9
Cr-Commit-Position: refs/heads/master@{#14825}

[danilchap, 2016-10-28 12:45:44]

danilchap@webrtc.org changed reviewers:
+ brandtr@webrtc.org

[danilchap, 2016-10-28 12:45:45]

ptal
slice of the https://codereview.webrtc.org/2452293004/ (i.e. would like to use
for that CL)

[brandtr, 2016-10-28 13:26:56]

https://codereview.webrtc.org/2457783005/diff/1/webrtc/modules/rtp_rtcp/sourc...
File webrtc/modules/rtp_rtcp/source/rtp_header_extensions.cc (right):

https://codereview.webrtc.org/2457783005/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtp_header_extensions.cc:35: constexpr uint8_t
AbsoluteSendTime::kValueSizeBytes;
Are the declarations above just for documentation, or do they have a specific
use?

https://codereview.webrtc.org/2457783005/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtp_header_extensions.cc:62: constexpr uint8_t
AudioLevel::kValueSizeBytes;
Same here, and below.

[danilchap, 2016-10-28 13:32:03]

https://codereview.webrtc.org/2457783005/diff/1/webrtc/modules/rtp_rtcp/sourc...
File webrtc/modules/rtp_rtcp/source/rtp_header_extensions.cc (right):

https://codereview.webrtc.org/2457783005/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtp_header_extensions.cc:35: constexpr uint8_t
AbsoluteSendTime::kValueSizeBytes;
On 2016/10/28 13:26:56, brandtr wrote:
> Are the declarations above just for documentation, or do they have a specific
> use?

presence of these declaration allows to use constants in RTC_DCHECK_EQ macros
and any other place where address of the kId can be taken.

[brandtr, 2016-10-28 13:46:04]

lgtm

On 2016/10/28 13:32:03, danilchap wrote:
>
https://codereview.webrtc.org/2457783005/diff/1/webrtc/modules/rtp_rtcp/sourc...
> File webrtc/modules/rtp_rtcp/source/rtp_header_extensions.cc (right):
> 
>
https://codereview.webrtc.org/2457783005/diff/1/webrtc/modules/rtp_rtcp/sourc...
> webrtc/modules/rtp_rtcp/source/rtp_header_extensions.cc:35: constexpr uint8_t
> AbsoluteSendTime::kValueSizeBytes;
> On 2016/10/28 13:26:56, brandtr wrote:
> > Are the declarations above just for documentation, or do they have a
specific
> > use?
> 
> presence of these declaration allows to use constants in RTC_DCHECK_EQ macros
> and any other place where address of the kId can be taken.

Ok. Assume you will do that in https://codereview.webrtc.org/2452293004/ ?

[danilchap, 2016-10-28 13:57:31]

On 2016/10/28 13:46:04, brandtr wrote:
> lgtm
> 
> On 2016/10/28 13:32:03, danilchap wrote:
> >
>
https://codereview.webrtc.org/2457783005/diff/1/webrtc/modules/rtp_rtcp/sourc...
> > File webrtc/modules/rtp_rtcp/source/rtp_header_extensions.cc (right):
> > 
> >
>
https://codereview.webrtc.org/2457783005/diff/1/webrtc/modules/rtp_rtcp/sourc...
> > webrtc/modules/rtp_rtcp/source/rtp_header_extensions.cc:35: constexpr
uint8_t
> > AbsoluteSendTime::kValueSizeBytes;
> > On 2016/10/28 13:26:56, brandtr wrote:
> > > Are the declarations above just for documentation, or do they have a
> specific
> > > use?
> > 
> > presence of these declaration allows to use constants in RTC_DCHECK_EQ
macros
> > and any other place where address of the kId can be taken.
> 
> Ok. Assume you will do that in https://codereview.webrtc.org/2452293004/ ?

That's not the main reason.
Technically program without those declaration is ill-formed - it was an error
not to include them in the first place.
Everything would work fine until someone decide to use the declaration (most
likely with a DCHECK_EQ or EXPECT_EQ).
https://github.com/google/googletest/blob/master/googletest/docs/FAQ.md#the-c...

[danilchap, 2016-10-28 14:07:36]

The CQ bit was checked by danilchap@webrtc.org

[commit-bot: I haz the power, 2016-10-28 14:07:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-10-28 14:09:01]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-28 14:09:08]

Description was changed from

==========
Style cleanups in rtp header extension traits:
renamed kName to kUri and make it more const.
remove IsSupportedBy to reduce header dependency.

BUG=webrtc:1994
==========

to

==========
Style cleanups in rtp header extension traits:
renamed kName to kUri and make it more const.
remove IsSupportedBy to reduce header dependency.

BUG=webrtc:1994

Committed: https://crrev.com/e2a017725570ead5946a4ca8235af27470ca0df9
Cr-Commit-Position: refs/heads/master@{#14825}
==========

[commit-bot: I haz the power, 2016-10-28 14:09:10]

Patchset 1 (id:??) landed as
https://crrev.com/e2a017725570ead5946a4ca8235af27470ca0df9
Cr-Commit-Position: refs/heads/master@{#14825}