Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2457203002: Revert of Reland Change ViEEncoder to not reconfigure the encoder until the video resolution is known. (Closed)

Created:
4 years, 1 month ago by emircan
Modified:
4 years, 1 month ago
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, the sun, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Reland Change ViEEncoder to not reconfigure the encoder until the video resolution is known. (patchset #2 id:20001 of https://codereview.webrtc.org/2455963004/ ) Reason for revert: It breaks webrtc.fyi bots, see https://build.chromium.org/p/chromium.webrtc.fyi/builders/Mac%20Tester/builds/35251. Original issue's description: > Reland Change ViEEncoder to not reconfigure the encoder until the video resolution is known. > > Patchset 1 contain the originally reviewed cl in https://codereview.webrtc.org/2455063002/ > TBR=stefan@webrtc.org, pbos@webrtc.org, skvlad@webrtc.org > > BUG=webrtc:6371 b/32285861 > > Committed: https://crrev.com/5f1b05129e4770c98429164761779d99a410e7c8 > Cr-Commit-Position: refs/heads/master@{#14823} TBR=pbos@webrtc.org,skvlad@webrtc.org,stefan@webrtc.org,perkj@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6371 b/32285861 Committed: https://crrev.com/05a55b500d83e4212d4e54f0fecf13097e782ffa Cr-Commit-Position: refs/heads/master@{#14829}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -67 lines) Patch
M webrtc/call/call_perf_tests.cc View 3 chunks +6 lines, -9 lines 0 comments Download
M webrtc/media/engine/webrtcvideoengine2_unittest.cc View 2 chunks +8 lines, -12 lines 0 comments Download
M webrtc/video/video_send_stream_tests.cc View 11 chunks +32 lines, -17 lines 0 comments Download
M webrtc/video/vie_encoder.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video/vie_encoder.cc View 2 chunks +10 lines, -9 lines 0 comments Download
M webrtc/video/vie_encoder_unittest.cc View 3 chunks +19 lines, -19 lines 0 comments Download

Messages

Total messages: 4 (3 generated)
emircan
4 years, 1 month ago (2016-10-28 21:06:02 UTC) #2
Created Revert of Reland Change ViEEncoder to not reconfigure the encoder until
the video resolution is known.

Powered by Google App Engine
This is Rietveld 408576698