Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 2457083002: Revert of Change ViEEncoder to not reconfigure the encoder until the video resolution is known. (Closed)

Created:
4 years, 1 month ago by perkj_webrtc
Modified:
4 years, 1 month ago
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Change ViEEncoder to not reconfigure the encoder until the video resolution is known. (patchset #4 id:60001 of https://codereview.webrtc.org/2455063002/ ) Reason for revert: Seems to break WebRTC perf tests. Original issue's description: > Change ViEEncoder to not reconfigure the encoder until the video resolution is known. > > BUG=b/32285861 > > Committed: https://crrev.com/461c29e436b5bd7ed019e83024e24dc8e86ec9b9 > Cr-Commit-Position: refs/heads/master@{#14813} TBR=skvlad@webrtc.org,pbos@webrtc.org,stefan@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=b/32285861 Committed: https://crrev.com/5da65f241c79c341b518db6868379835f0e24f0f Cr-Commit-Position: refs/heads/master@{#14815}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -58 lines) Patch
M webrtc/media/engine/webrtcvideoengine2_unittest.cc View 2 chunks +8 lines, -12 lines 0 comments Download
M webrtc/video/video_send_stream_tests.cc View 11 chunks +32 lines, -17 lines 0 comments Download
M webrtc/video/vie_encoder.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video/vie_encoder.cc View 2 chunks +10 lines, -9 lines 0 comments Download
M webrtc/video/vie_encoder_unittest.cc View 3 chunks +19 lines, -19 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
perkj_webrtc
Created Revert of Change ViEEncoder to not reconfigure the encoder until the video resolution is ...
4 years, 1 month ago (2016-10-28 11:48:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2457083002/1
4 years, 1 month ago (2016-10-28 11:48:43 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-28 11:48:50 UTC) #4
commit-bot: I haz the power
4 years, 1 month ago (2016-10-28 11:49:03 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5da65f241c79c341b518db6868379835f0e24f0f
Cr-Commit-Position: refs/heads/master@{#14815}

Powered by Google App Engine
This is Rietveld 408576698