Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Side by Side Diff: webrtc/base/task_queue_unittest.cc

Issue 2456523002: Disable TaskQueueTest.PostDelayed because of flakiness (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2016 The WebRTC Project Authors. All rights reserved. 2 * Copyright 2016 The WebRTC Project Authors. All rights reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 73 matching lines...) Expand 10 before | Expand all | Expand 10 after
84 TEST(TaskQueueTest, PostFromQueue) { 84 TEST(TaskQueueTest, PostFromQueue) {
85 static const char kQueueName[] = "PostFromQueue"; 85 static const char kQueueName[] = "PostFromQueue";
86 TaskQueue queue(kQueueName); 86 TaskQueue queue(kQueueName);
87 87
88 Event event(false, false); 88 Event event(false, false);
89 queue.PostTask( 89 queue.PostTask(
90 [&event, &queue]() { queue.PostTask([&event]() { event.Set(); }); }); 90 [&event, &queue]() { queue.PostTask([&event]() { event.Set(); }); });
91 EXPECT_TRUE(event.Wait(1000)); 91 EXPECT_TRUE(event.Wait(1000));
92 } 92 }
93 93
94 TEST(TaskQueueTest, PostDelayed) { 94 TEST(TaskQueueTest, DISABLED_PostDelayed) {
95 static const char kQueueName[] = "PostDelayed"; 95 static const char kQueueName[] = "PostDelayed";
96 TaskQueue queue(kQueueName); 96 TaskQueue queue(kQueueName);
97 97
98 Event event(false, false); 98 Event event(false, false);
99 uint32_t start = Time(); 99 uint32_t start = Time();
100 queue.PostDelayedTask(Bind(&CheckCurrent, kQueueName, &event, &queue), 100); 100 queue.PostDelayedTask(Bind(&CheckCurrent, kQueueName, &event, &queue), 100);
101 EXPECT_TRUE(event.Wait(1000)); 101 EXPECT_TRUE(event.Wait(1000));
102 uint32_t end = Time(); 102 uint32_t end = Time();
103 EXPECT_GE(end - start, 100u); 103 EXPECT_GE(end - start, 100u);
104 EXPECT_NEAR(end - start, 200u, 100u); // Accept 100-300. 104 EXPECT_NEAR(end - start, 200u, 100u); // Accept 100-300.
(...skipping 144 matching lines...) Expand 10 before | Expand all | Expand 10 after
249 queue.PostTask(NewClosure([&tasks_executed]() { ++tasks_executed; }, 249 queue.PostTask(NewClosure([&tasks_executed]() { ++tasks_executed; },
250 [&tasks_cleaned_up]() { ++tasks_cleaned_up; })); 250 [&tasks_cleaned_up]() { ++tasks_cleaned_up; }));
251 event.Set(); // Unblock the first task. 251 event.Set(); // Unblock the first task.
252 } 252 }
253 253
254 EXPECT_GE(tasks_cleaned_up, tasks_executed); 254 EXPECT_GE(tasks_cleaned_up, tasks_executed);
255 EXPECT_EQ(kTaskCount, tasks_cleaned_up); 255 EXPECT_EQ(kTaskCount, tasks_cleaned_up);
256 } 256 }
257 257
258 } // namespace rtc 258 } // namespace rtc
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698