Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 2455963004: Reland Change ViEEncoder to not reconfigure the encoder until the video resolution is known. (Closed)

Created:
4 years, 1 month ago by perkj_webrtc
Modified:
4 years, 1 month ago
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, the sun, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland Change ViEEncoder to not reconfigure the encoder until the video resolution is known. Patchset 1 contain the originally reviewed cl in https://codereview.webrtc.org/2455063002/ TBR=stefan@webrtc.org, pbos@webrtc.org, skvlad@webrtc.org BUG=webrtc:6371 b/32285861 Committed: https://crrev.com/5f1b05129e4770c98429164761779d99a410e7c8 Cr-Commit-Position: refs/heads/master@{#14823}

Patch Set 1 #

Patch Set 2 : Fix test KeepsHighBitrateWhenReconfiguringSender #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -65 lines) Patch
M webrtc/call/call_perf_tests.cc View 1 3 chunks +9 lines, -6 lines 0 comments Download
M webrtc/media/engine/webrtcvideoengine2_unittest.cc View 2 chunks +12 lines, -8 lines 0 comments Download
M webrtc/video/video_send_stream_tests.cc View 11 chunks +17 lines, -32 lines 0 comments Download
M webrtc/video/vie_encoder.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video/vie_encoder.cc View 2 chunks +9 lines, -10 lines 0 comments Download
M webrtc/video/vie_encoder_unittest.cc View 4 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
perkj_webrtc
Here we go again.
4 years, 1 month ago (2016-10-28 13:36:17 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2455963004/20001
4 years, 1 month ago (2016-10-28 13:36:24 UTC) #3
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-10-28 13:58:42 UTC) #4
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/5f1b05129e4770c98429164761779d99a410e7c8 Cr-Commit-Position: refs/heads/master@{#14823}
4 years, 1 month ago (2016-10-28 13:58:48 UTC) #6
emircan
4 years, 1 month ago (2016-10-28 21:06:02 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.webrtc.org/2457203002/ by emircan@chromium.org.

The reason for reverting is: It breaks webrtc.fyi bots, see
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Mac%20Tester/builds....

Powered by Google App Engine
This is Rietveld 408576698