Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Unified Diff: webrtc/modules/rtp_rtcp/source/rtp_sender_video.cc

Issue 2455963003: Simplify SetFecParameters signature. (Closed)
Patch Set: Feedback response 1. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/rtp_rtcp/source/rtp_sender_video.cc
diff --git a/webrtc/modules/rtp_rtcp/source/rtp_sender_video.cc b/webrtc/modules/rtp_rtcp/source/rtp_sender_video.cc
index 8f14d653687ddd1bebe0228664af951863313623..07c5348f4b683f11a533b7a1fe2ea69a7c48e2c5 100644
--- a/webrtc/modules/rtp_rtcp/source/rtp_sender_video.cc
+++ b/webrtc/modules/rtp_rtcp/source/rtp_sender_video.cc
@@ -221,14 +221,12 @@ size_t RTPSenderVideo::FecPacketOverhead() const {
return overhead;
}
-void RTPSenderVideo::SetFecParameters(const FecProtectionParams* delta_params,
- const FecProtectionParams* key_params) {
+void RTPSenderVideo::SetFecParameters(const FecProtectionParams& delta_params,
+ const FecProtectionParams& key_params) {
rtc::CritScope cs(&crit_);
- RTC_DCHECK(delta_params);
- RTC_DCHECK(key_params);
if (ulpfec_enabled()) {
- delta_fec_params_ = *delta_params;
- key_fec_params_ = *key_params;
+ delta_fec_params_ = delta_params;
+ key_fec_params_ = key_params;
}
}
@@ -286,8 +284,8 @@ bool RTPSenderVideo::SendVideo(RtpVideoCodecTypes video_type,
bool first_frame = first_frame_sent_();
{
rtc::CritScope cs(&crit_);
- FecProtectionParams* fec_params =
- frame_type == kVideoFrameKey ? &key_fec_params_ : &delta_fec_params_;
+ const FecProtectionParams& fec_params =
+ frame_type == kVideoFrameKey ? key_fec_params_ : delta_fec_params_;
producer_fec_.SetFecParameters(fec_params);
storage = packetizer->GetStorageType(retransmission_settings_);
_red_enabled = red_enabled();

Powered by Google App Engine
This is Rietveld 408576698