Chromium Code Reviews

Unified Diff: webrtc/modules/rtp_rtcp/source/rtp_sender.cc

Issue 2455963003: Simplify SetFecParameters signature. (Closed)
Patch Set: Feedback response 1. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Index: webrtc/modules/rtp_rtcp/source/rtp_sender.cc
diff --git a/webrtc/modules/rtp_rtcp/source/rtp_sender.cc b/webrtc/modules/rtp_rtcp/source/rtp_sender.cc
index b8db61b3c5b020ddb2840c65973250813d236c08..4e407ee2bc33b3b64bf0873a1ff99853226f0412 100644
--- a/webrtc/modules/rtp_rtcp/source/rtp_sender.cc
+++ b/webrtc/modules/rtp_rtcp/source/rtp_sender.cc
@@ -1136,14 +1136,13 @@ void RTPSender::SetUlpfecConfig(int red_payload_type, int ulpfec_payload_type) {
video_->SetUlpfecConfig(red_payload_type, ulpfec_payload_type);
}
-int32_t RTPSender::SetFecParameters(
- const FecProtectionParams *delta_params,
- const FecProtectionParams *key_params) {
+bool RTPSender::SetFecParameters(const FecProtectionParams& delta_params,
+ const FecProtectionParams& key_params) {
if (audio_configured_) {
- return -1;
+ return false;
}
video_->SetFecParameters(delta_params, key_params);
- return 0;
+ return true;
}
std::unique_ptr<RtpPacketToSend> RTPSender::BuildRtxPacket(

Powered by Google App Engine