Chromium Code Reviews

Unified Diff: webrtc/modules/rtp_rtcp/include/rtp_rtcp.h

Issue 2455963003: Simplify SetFecParameters signature. (Closed)
Patch Set: Feedback response 1. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Index: webrtc/modules/rtp_rtcp/include/rtp_rtcp.h
diff --git a/webrtc/modules/rtp_rtcp/include/rtp_rtcp.h b/webrtc/modules/rtp_rtcp/include/rtp_rtcp.h
index 4dda74d3432b21b751fe497aae44f08e94955cb5..cc5575c2496565db33a62620b08119af150fb9d7 100644
--- a/webrtc/modules/rtp_rtcp/include/rtp_rtcp.h
+++ b/webrtc/modules/rtp_rtcp/include/rtp_rtcp.h
@@ -17,6 +17,7 @@
#include <vector>
#include "webrtc/base/constructormagic.h"
+#include "webrtc/base/deprecation.h"
#include "webrtc/modules/include/module.h"
#include "webrtc/modules/rtp_rtcp/include/rtp_rtcp_defines.h"
#include "webrtc/modules/video_coding/include/video_coding_defines.h"
@@ -459,8 +460,15 @@ class RtpRtcp : public Module {
virtual void SetUlpfecConfig(int red_payload_type,
int ulpfec_payload_type) = 0;
- virtual int32_t SetFecParameters(const FecProtectionParams* delta_params,
- const FecProtectionParams* key_params) = 0;
+ // Set FEC rates, max frames before FEC is sent, and type of FEC masks.
+ // Returns false on failure.
+ virtual bool SetFecParameters(const FecProtectionParams& delta_params,
+ const FecProtectionParams& key_params) = 0;
+
+ // Deprecated version of member function above.
+ RTC_DEPRECATED
+ int32_t SetFecParameters(const FecProtectionParams* delta_params,
+ const FecProtectionParams* key_params);
// Set method for requestion a new key frame.
// Returns -1 on failure else 0.
« no previous file with comments | « no previous file | webrtc/modules/rtp_rtcp/mocks/mock_rtp_rtcp.h » ('j') | webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc » ('J')

Powered by Google App Engine