webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc - Issue 2455963003: Simplify SetFecParameters signature.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc

Issue 2455963003: Simplify SetFecParameters signature. (Closed)

Patch Set: Return type int32_t replaced by bool and void. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc

diff --git a/webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc b/webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc

index fa8db8a4c4a2bb989e39b76e87bb8e0c451bbfd3..d02d25eb2134166e0ec4a6dc1c362a5982f2c934 100644

--- a/webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc

+++ b/webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc

@@ -1129,7 +1129,7 @@ TEST_F(RtpSenderTestWithoutPacer, StreamDataCountersCallbacks) {

fec_params.fec_mask_type = kFecMaskRandom;

fec_params.fec_rate = 1;

fec_params.max_fec_frames = 1;

- rtp_sender_->SetFecParameters(&fec_params, &fec_params);

+ rtp_sender_->SetFecParameters(fec_params, fec_params);

ASSERT_TRUE(rtp_sender_->SendOutgoingData(

kVideoFrameDelta, payload_type, 1234, 4321, payload,

sizeof(payload), nullptr, nullptr, nullptr));