webrtc/modules/rtp_rtcp/source/flexfec_sender_impl.cc - Issue 2455963003: Simplify SetFecParameters signature.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/rtp_rtcp/source/flexfec_sender_impl.cc

Issue 2455963003: Simplify SetFecParameters signature. (Closed)

Patch Set: Return type int32_t replaced by bool and void. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/rtp_rtcp/source/flexfec_sender_impl.cc

diff --git a/webrtc/modules/rtp_rtcp/source/flexfec_sender_impl.cc b/webrtc/modules/rtp_rtcp/source/flexfec_sender_impl.cc

index a186921154a4fc57507aed921f13be798c762464..408fa272f1f108b7e34ffc71a7de70f4859237eb 100644

--- a/webrtc/modules/rtp_rtcp/source/flexfec_sender_impl.cc

+++ b/webrtc/modules/rtp_rtcp/source/flexfec_sender_impl.cc

@@ -101,7 +101,7 @@ FlexfecSenderImpl::~FlexfecSenderImpl() = default;

// AddRtpPacketAndGenerateFec, and FecAvailable.

void FlexfecSenderImpl::SetFecParameters(const FecProtectionParams& params) {

RTC_DCHECK_CALLED_SEQUENTIALLY(&sequence_checker_);

- ulpfec_generator_.SetFecParameters(&params);

+ ulpfec_generator_.SetFecParameters(params);

}

bool FlexfecSenderImpl::AddRtpPacketAndGenerateFec(