Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(638)

Issue 2455413002: Remove unnecessary styling for some controls in ARDMainView.m for ios. (Closed)

Created:
4 years, 1 month ago by daniela-webrtc
Modified:
4 years, 1 month ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove unnecessary styling for some controls in ARDMainView.m for ios. They can be removed and we can use the default system controls. It's less code and also has more native look. BUG=webrtc:6617 Committed: https://crrev.com/ae70876c00ac644bcef8c274e1f12162f9b936d3 Cr-Commit-Position: refs/heads/master@{#14882}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -63 lines) Patch
M webrtc/examples/objc/AppRTCMobile/ios/ARDMainView.m View 8 chunks +4 lines, -63 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
daniela-webrtc
4 years, 1 month ago (2016-11-01 09:55:48 UTC) #2
magjed_webrtc
lgtm, this removes code and I think the UI looks more professional, even though I ...
4 years, 1 month ago (2016-11-01 12:24:04 UTC) #4
tkchin_webrtc
On 2016/11/01 12:24:04, magjed_webrtc wrote: > lgtm, this removes code and I think the UI ...
4 years, 1 month ago (2016-11-01 20:33:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2455413002/1
4 years, 1 month ago (2016-11-02 09:32:59 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-02 10:02:32 UTC) #8
commit-bot: I haz the power
4 years, 1 month ago (2016-11-02 10:02:42 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ae70876c00ac644bcef8c274e1f12162f9b936d3
Cr-Commit-Position: refs/heads/master@{#14882}

Powered by Google App Engine
This is Rietveld 408576698