Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 2455363002: Add UINavigationController to AppRTCMobile. (Closed)

Created:
4 years, 1 month ago by daniela-webrtc
Modified:
4 years, 1 month ago
Reviewers:
magjed_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add UINavigationController and settings bar button to AppRTCMobile. The navigation controller is used to display the title of the app and to feature the settings button. This work is foundation for adding settings screen to the app (see webrtc:6473 for more info) BUG=webrtc:6618, webrtc:6473 Committed: https://crrev.com/6d6762cb0e236acd3231d1fba8ad590b43156d51 Cr-Commit-Position: refs/heads/master@{#14816}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -14 lines) Patch
M webrtc/examples/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/examples/objc/AppRTCMobile/ios/ARDAppDelegate.m View 1 chunk +5 lines, -1 line 0 comments Download
M webrtc/examples/objc/AppRTCMobile/ios/ARDMainView.m View 3 chunks +2 lines, -13 lines 0 comments Download
M webrtc/examples/objc/AppRTCMobile/ios/ARDMainViewController.m View 4 chunks +15 lines, -0 lines 0 comments Download
A webrtc/examples/objc/AppRTCMobile/ios/resources/ic_settings_black_24dp.png View Binary file 0 comments Download
A webrtc/examples/objc/AppRTCMobile/ios/resources/ic_settings_black_24dp@2x.png View Binary file 0 comments Download

Messages

Total messages: 12 (6 generated)
daniela-webrtc
4 years, 1 month ago (2016-10-28 08:56:46 UTC) #4
magjed_webrtc
lgtm! One question unrelated to the code: where are the png files taken from? Are ...
4 years, 1 month ago (2016-10-28 09:12:46 UTC) #5
daniela-webrtc
On 2016/10/28 09:12:46, magjed_webrtc wrote: > lgtm! One question unrelated to the code: where are ...
4 years, 1 month ago (2016-10-28 10:49:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2455363002/1
4 years, 1 month ago (2016-10-28 10:49:42 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-28 11:53:19 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-10-28 11:53:24 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6d6762cb0e236acd3231d1fba8ad590b43156d51
Cr-Commit-Position: refs/heads/master@{#14816}

Powered by Google App Engine
This is Rietveld 408576698