Change ViEEncoder to not reconfigure the encoder until the video resolution is known.

Change ViEEncoder to not reconfigure the encoder until the video resolution is known.

BUG=b/32285861

Committed: https://crrev.com/461c29e436b5bd7ed019e83024e24dc8e86ec9b9
Cr-Commit-Position: refs/heads/master@{#14813}

[perkj_webrtc, 2016-10-27 13:12:57]

Description was changed from

==========
Change ViEEncoder to not reconfigure the encoder until the video resolution is
known.

BUG=
==========

to

==========
Change ViEEncoder to not reconfigure the encoder until the video resolution is
known.

BUG=b/32285861
==========

[perkj_webrtc, 2016-10-27 13:12:57]

perkj@webrtc.org changed reviewers:
+ pbos@webrtc.org, skvlad@webrtc.org, stefan@webrtc.org

[perkj_webrtc, 2016-10-27 13:15:21]

please

[pbos-webrtc, 2016-10-27 15:31:13]

On 2016/10/27 13:15:21, perkj_webrtc wrote:
> please

Looks like media unittests are flaking, perhaps they still wait one time too
many after this change. Please run this through gtest-parallel a ton of times

[perkj_webrtc, 2016-10-27 16:13:35]

The test was not flaky. I had simply not ran all of them locally.... 

But now I run all rtc_media_unittests as well.

Turns out that someone have written more tests that depend on the this behavior
in ViEEncoder.

[pbos-webrtc, 2016-10-27 16:26:48]

On 2016/10/27 16:13:35, perkj_webrtc wrote:
> The test was not flaky. I had simply not ran all of them locally.... 
> 
> But now I run all rtc_media_unittests as well.
> 
> Turns out that someone have written more tests that depend on the this
behavior
> in ViEEncoder.

Was that someone me perhaps? (:

I'm curious whether this degrades Chrome performance since the encoder won't be
preinitialized, but I'm not sure if RtcVideoEncoder or libvpx is actually faster
to reinitialize than initialize. Feel free to investigate if curious.

lgtm

[skvlad, 2016-10-27 21:09:32]

lgtm. Thanks for doing this so quickly!

[perkj_webrtc, 2016-10-28 09:47:53]

Committing since Stefan is OOO.

[perkj_webrtc, 2016-10-28 09:47:58]

The CQ bit was checked by perkj@webrtc.org

[commit-bot: I haz the power, 2016-10-28 09:48:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-10-28 10:13:52]

Description was changed from

==========
Change ViEEncoder to not reconfigure the encoder until the video resolution is
known.

BUG=b/32285861
==========

to

==========
Change ViEEncoder to not reconfigure the encoder until the video resolution is
known.

BUG=b/32285861
==========

[commit-bot: I haz the power, 2016-10-28 10:13:53]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-10-28 10:14:03]

Description was changed from

==========
Change ViEEncoder to not reconfigure the encoder until the video resolution is
known.

BUG=b/32285861
==========

to

==========
Change ViEEncoder to not reconfigure the encoder until the video resolution is
known.

BUG=b/32285861

Committed: https://crrev.com/461c29e436b5bd7ed019e83024e24dc8e86ec9b9
Cr-Commit-Position: refs/heads/master@{#14813}
==========

[commit-bot: I haz the power, 2016-10-28 10:14:04]

Patchset 4 (id:??) landed as
https://crrev.com/461c29e436b5bd7ed019e83024e24dc8e86ec9b9
Cr-Commit-Position: refs/heads/master@{#14813}

[perkj_webrtc, 2016-10-28 11:48:34]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.webrtc.org/2457083002/ by perkj@webrtc.org.

The reason for reverting is: Seems to break WebRTC perf tests..