Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issue 2454963002: Add gn_isolate_map.pyl file for WebRTC stand-alone tests (Closed)

Created:
4 years, 1 month ago by kjellander_webrtc
Modified:
4 years, 1 month ago
Reviewers:
ehmaldonado_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add gn_isolate_map.pyl file for WebRTC stand-alone tests With this, MB can be invoked with the new --isolate-map-file flag that was added in https://codereview.chromium.org/2443643002. BUG=chromium:497757 NOTRY=True TESTED=Created /tmp/foo and filled it with targets from https://build.chromium.org/p/client.webrtc/builders/Linux32%20Debug/builds/9305/steps/generate_build_files/logs/swarming-targets-file.txt Then I sucessfully ran: tools/mb/mb.py gen -m client.webrtc -b 'Linux32 Debug' --config-file webrtc/build/mb_config.pyl --swarming-targets-file /tmp/foo --gyp-script=webrtc/build/gyp_webrtc.py --isolate-map-file=webrtc/build/gn_isolate_map.pyl //out/Debug Committed: https://crrev.com/bc59b061a7b2b6302a6446d0dcca2a76102cf587 Cr-Commit-Position: refs/heads/master@{#14795}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -0 lines) Patch
A webrtc/build/gn_isolate_map.pyl View 1 chunk +102 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
kjellander_webrtc
4 years, 1 month ago (2016-10-27 06:30:59 UTC) #2
ehmaldonado_webrtc
On 2016/10/27 06:30:59, kjellander_webrtc wrote: LGTM. Awesome!
4 years, 1 month ago (2016-10-27 06:52:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2454963002/1
4 years, 1 month ago (2016-10-27 06:54:09 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-27 06:55:27 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-10-27 06:55:31 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bc59b061a7b2b6302a6446d0dcca2a76102cf587
Cr-Commit-Position: refs/heads/master@{#14795}

Powered by Google App Engine
This is Rietveld 408576698