Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1248)

Unified Diff: webrtc/audio/audio_state.h

Issue 2454373002: Added an empty AudioTransportProxy to AudioState. (Closed)
Patch Set: Added unit test for recorded data path. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/audio/audio_state.h
diff --git a/webrtc/audio/audio_state.h b/webrtc/audio/audio_state.h
index 31892d04faaa5141b9e25d9486553da4ce101b11..c1af5ab98c03beb57c34eaaacfca95633b3c9378 100644
--- a/webrtc/audio/audio_state.h
+++ b/webrtc/audio/audio_state.h
@@ -11,7 +11,9 @@
#ifndef WEBRTC_AUDIO_AUDIO_STATE_H_
#define WEBRTC_AUDIO_AUDIO_STATE_H_
+#include "webrtc/api/audio/audio_mixer.h"
the sun 2016/11/14 13:50:08 This include should be in audio_state.h instead, r
aleloi 2016/11/14 14:24:42 I'm not sure. I think there is a similar relations
the sun 2016/11/14 18:13:24 Right, so by that logic, since the base class' hea
#include "webrtc/api/call/audio_state.h"
+#include "webrtc/audio/audio_transport_proxy.h"
#include "webrtc/audio/scoped_voe_interface.h"
#include "webrtc/base/constructormagic.h"
#include "webrtc/base/criticalsection.h"
@@ -28,6 +30,8 @@ class AudioState final : public webrtc::AudioState,
~AudioState() override;
VoiceEngine* voice_engine();
+
+ rtc::scoped_refptr<AudioMixer> mixer() const;
the sun 2016/11/14 13:50:08 Remove const - you're returning a non-const pointe
aleloi 2016/11/14 14:24:42 Makes sense! I think it's called logical constness
bool typing_noise_detected() const;
private:
@@ -53,6 +57,10 @@ class AudioState final : public webrtc::AudioState,
// Reference count; implementation copied from rtc::RefCountedObject.
mutable volatile int ref_count_ = 0;
+ // Transports mixed audio from the mixer to the audio device and
+ // recorded audio to the VoE AudioTransport.
+ AudioTransportProxy audio_transport_proxy_;
+
RTC_DISALLOW_IMPLICIT_CONSTRUCTORS(AudioState);
};
} // namespace internal

Powered by Google App Engine
This is Rietveld 408576698