Add unit tests for bandwidth limited resolution stats in SendStatisticsProxy.

Add unit tests for bandwidth limited resolution stats in SendStatisticsProxy.

BUG=none

Committed: https://crrev.com/4ee704699825f59cf80d130c12001430e687112b
Cr-Commit-Position: refs/heads/master@{#14844}

[åsapersson, 2016-10-28 10:06:47]

Description was changed from

==========
Add unit tests for bandwidth limited resolution stats in SendStatisticsProxy.

BUG=none
==========

to

==========
Add unit tests for bandwidth limited resolution stats in SendStatisticsProxy.

BUG=none
==========

[åsapersson, 2016-10-28 10:06:47]

asapersson@webrtc.org changed reviewers:
+ sprang@webrtc.org, stefan@webrtc.org

[stefan-webrtc, 2016-10-31 09:46:25]

lgtm

https://codereview.webrtc.org/2454343002/diff/20001/webrtc/video/send_statist...
File webrtc/video/send_statistics_proxy_unittest.cc (right):

https://codereview.webrtc.org/2454343002/diff/20001/webrtc/video/send_statist...
webrtc/video/send_statistics_proxy_unittest.cc:437: statistics_proxy_.reset();
Why reset?

[åsapersson, 2016-10-31 10:06:20]

On 2016/10/31 09:46:25, stefan-webrtc (holmer) wrote:
> lgtm
> 
>
https://codereview.webrtc.org/2454343002/diff/20001/webrtc/video/send_statist...
> File webrtc/video/send_statistics_proxy_unittest.cc (right):
> 
>
https://codereview.webrtc.org/2454343002/diff/20001/webrtc/video/send_statist...
> webrtc/video/send_statistics_proxy_unittest.cc:437: statistics_proxy_.reset();
> Why reset?

Added comment. Histograms are updated when the stats proxy is deleted.

[åsapersson, 2016-10-31 10:07:27]

https://codereview.webrtc.org/2454343002/diff/20001/webrtc/video/send_statist...
File webrtc/video/send_statistics_proxy_unittest.cc (right):

https://codereview.webrtc.org/2454343002/diff/20001/webrtc/video/send_statist...
webrtc/video/send_statistics_proxy_unittest.cc:437: statistics_proxy_.reset();
On 2016/10/31 09:46:25, stefan-webrtc (holmer) wrote:
> Why reset?

Added comment.

[åsapersson, 2016-10-31 10:13:42]

The CQ bit was checked by asapersson@webrtc.org

[åsapersson, 2016-10-31 10:13:43]

The patchset sent to the CQ was uploaded after l-g-t-m from stefan@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2454343002/#ps40001 (title:
"add comment")

[commit-bot: I haz the power, 2016-10-31 10:13:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-10-31 11:05:14]

Description was changed from

==========
Add unit tests for bandwidth limited resolution stats in SendStatisticsProxy.

BUG=none
==========

to

==========
Add unit tests for bandwidth limited resolution stats in SendStatisticsProxy.

BUG=none
==========

[commit-bot: I haz the power, 2016-10-31 11:05:15]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-31 11:05:26]

Description was changed from

==========
Add unit tests for bandwidth limited resolution stats in SendStatisticsProxy.

BUG=none
==========

to

==========
Add unit tests for bandwidth limited resolution stats in SendStatisticsProxy.

BUG=none

Committed: https://crrev.com/4ee704699825f59cf80d130c12001430e687112b
Cr-Commit-Position: refs/heads/master@{#14844}
==========

[commit-bot: I haz the power, 2016-10-31 11:05:28]

Patchset 3 (id:??) landed as
https://crrev.com/4ee704699825f59cf80d130c12001430e687112b
Cr-Commit-Position: refs/heads/master@{#14844}