Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 2454293003: Moved rtc::Base64 to base approved. (Closed)

Created:
4 years, 1 month ago by philipel
Modified:
4 years, 1 month ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M webrtc/base/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/base/base64.cc View 3 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
philipel
PTAL
4 years, 1 month ago (2016-10-28 12:00:11 UTC) #2
tommi
lgtm
4 years, 1 month ago (2016-10-28 12:02:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2454293003/1
4 years, 1 month ago (2016-10-28 12:02:49 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/9632)
4 years, 1 month ago (2016-10-28 12:08:00 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a9a1ac2ab87ad7e8801579871e3f31fc3581e5c3 Cr-Commit-Position: refs/heads/master@{#14819}
4 years, 1 month ago (2016-10-28 12:23:29 UTC) #9
philipel
4 years, 1 month ago (2016-10-28 12:23:30 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a9a1ac2ab87ad7e8801579871e3f31fc3581e5c3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698