Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 2453593003: MB: Add Linux swarming bots with memory sanitizers on the FYI waterfall. (Closed)

Created:
4 years, 1 month ago by ehmaldonado_webrtc
Modified:
4 years, 1 month ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

MB: Add Linux swarming bots with memory sanitizers on the FYI waterfall. R=kjellander@webrtc.org BUG=chromium:497757 NOTRY=True Committed: https://crrev.com/5819660f9d9d9223ff896bdfec0808bd466f7ac4 Cr-Commit-Position: refs/heads/master@{#14787}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Addressed comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M webrtc/build/mb_config.pyl View 1 2 chunks +7 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
ehmaldonado_webrtc
4 years, 1 month ago (2016-10-26 13:52:48 UTC) #1
kjellander_webrtc
lgtm with nit addressed. https://codereview.webrtc.org/2453593003/diff/1/webrtc/build/mb_config.pyl File webrtc/build/mb_config.pyl (right): https://codereview.webrtc.org/2453593003/diff/1/webrtc/build/mb_config.pyl#newcode103 webrtc/build/mb_config.pyl:103: Remove blank line.
4 years, 1 month ago (2016-10-26 13:57:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2453593003/20001
4 years, 1 month ago (2016-10-26 13:59:11 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-10-26 14:00:31 UTC) #8
commit-bot: I haz the power
4 years, 1 month ago (2016-10-26 14:00:37 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5819660f9d9d9223ff896bdfec0808bd466f7ac4
Cr-Commit-Position: refs/heads/master@{#14787}

Powered by Google App Engine
This is Rietveld 408576698