Delete method FrameObject::GetBitstream.

Delete method FrameObject::GetBitstream.

Also change FrameObject::size member to a method, returning the underlying
EncodedImage attribute.

BUG=None

[nisse-webrtc, 2016-10-27 09:25:16]

nisse@webrtc.org changed reviewers:
+ philipel@webrtc.org

[nisse-webrtc, 2016-10-27 09:25:17]

Please take a look. As long as we do use an underlying EncodedImage, we
shouldn't duplicate what's in there.

[philipel, 2016-10-27 10:39:36]

Given the offline discussion I think we should keep the change to size but not
remove GetBitstream().

I also suggest we add GetDataPointer() which will return a pointer to a
continuous piece of memory containing the bitstream for this frame.

[nisse-webrtc, 2016-10-27 11:31:34]

On 2016/10/27 10:39:36, philipel wrote:
> Given the offline discussion I think we should keep the change to size but not
> remove GetBitstream().

Ok, see cl https://codereview.webrtc.org/2444193010/. I'm going to close this
one.

> I also suggest we add GetDataPointer() which will return a pointer to a
> continuous piece of memory containing the bitstream for this frame.

Maybe, but there's no point in adding it until it's actually needed.

BTW, I also have some concerns regarding naming in this class. I think
CopyBitstream would be clearer than GetBitstream. And I don't quite like the
class name "FrameObject" either. First, it's useless to tack on "Object" on the
name of a type. Second, as far as I understand, it's intended to represent
encoded data only (unlike webrtc::VideoFrame), and I think it would aid clarity
to have that in the name. So I'd suggest naming the class EncodedFrame.

From my use of this class, I think it represents precisely the information that
needs to be transferred over the wire in a quartc frame (or in a future
refactored rtp transport).

[nisse-webrtc, 2016-10-27 11:32:05]

Description was changed from

==========
Delete method FrameObject::GetBitstream.

Also change FrameObject::;113~size member to a method, returning the underlying
EncodedImage attribute.

BUG=None
==========

to

==========
Delete method FrameObject::GetBitstream.

Also change FrameObject::size member to a method, returning the underlying
EncodedImage attribute.

BUG=None
==========