Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 2452643002: Revert of Clean up logging in AudioSendStream::SetupSendCodec(). (Closed)

Created:
4 years, 1 month ago by terelius
Modified:
4 years, 1 month ago
Reviewers:
the sun, kwiberg-webrtc
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, yujie_mao (webrtc), tlegrand-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc, the sun
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Clean up logging in AudioSendStream::SetupSendCodec(). (patchset #3 id:40001 of https://codereview.webrtc.org/2446963003/ ) Reason for revert: Breaks downstream project Original issue's description: > Clean up logging in AudioSendStream::SetupSendCodec(). > > As a side effect: > - Moved the AudioSendStream::Config::SendCodecSpec methods into the .cc. > - Which exposed an issue with event_visualizer_utils not having a dependency on api:call_api set up. > - Which further exposed clang warnings about large inlined default methods in webrtc/config.h. > > BUG=webrtc:4690 > > Committed: https://crrev.com/1836fd6257a692959b3b49ba99ef587ad9995871 > Cr-Commit-Position: refs/heads/master@{#14771} TBR=kwiberg@webrtc.org,solenberg@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:4690 Committed: https://crrev.com/189f9b1b6580f6d67c05b18f5b2d60654d7663d7 Cr-Commit-Position: refs/heads/master@{#14774}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -183 lines) Patch
M webrtc/api/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/api/call/audio_send_stream.h View 3 chunks +37 lines, -9 lines 0 comments Download
D webrtc/api/call/audio_send_stream.cc View 1 chunk +0 lines, -118 lines 0 comments Download
M webrtc/audio/audio_send_stream.cc View 5 chunks +82 lines, -17 lines 0 comments Download
M webrtc/audio/audio_send_stream_unittest.cc View 1 chunk +2 lines, -16 lines 0 comments Download
M webrtc/config.h View 6 chunks +7 lines, -8 lines 0 comments Download
M webrtc/config.cc View 4 chunks +0 lines, -13 lines 0 comments Download
M webrtc/logging/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
terelius
Created Revert of Clean up logging in AudioSendStream::SetupSendCodec().
4 years, 1 month ago (2016-10-25 14:56:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2452643002/1
4 years, 1 month ago (2016-10-25 14:56:32 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-25 14:56:40 UTC) #4
commit-bot: I haz the power
4 years, 1 month ago (2016-10-25 14:56:50 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/189f9b1b6580f6d67c05b18f5b2d60654d7663d7
Cr-Commit-Position: refs/heads/master@{#14774}

Powered by Google App Engine
This is Rietveld 408576698