Follow standard sending CVO rtp header extension

Follow standard sending CVO rtp header extension
Include CVO in key frame.
Include CVO in delta frame when rotation changes.
Include CVO when it is non zero to support current receiver implementation.

BUG=webrtc:6600
Committed: https://crrev.com/c1600c56959fcf25ca9e3a93342155d781c1bcd2
Cr-Commit-Position: refs/heads/master@{#14784}

[danilchap, 2016-10-25 12:42:34]

danilchap@webrtc.org changed reviewers:
+ sprang@google.com

[sprang_webrtc, 2016-10-25 13:39:02]

sprang@webrtc.org changed reviewers:
+ sprang@webrtc.org

[sprang_webrtc, 2016-10-25 13:39:02]

https://codereview.webrtc.org/2452583002/diff/1/webrtc/modules/rtp_rtcp/sourc...
File webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc (right):

https://codereview.webrtc.org/2452583002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc:1497:
EXPECT_EQ(kVideoRotation_90, rotation);
There seems to be a bunch of code duplication between the test cases here. Can
you create a subclass or helper class with the common bits?

[danilchap, 2016-10-25 14:35:39]

Description was changed from

==========
Follow standard sending CVO rtp header extension
Include CVO in key frame.
Include CVO in delta frame when rotation changes.
Include CVO when it is non zero to support current receiver implementation.

BUG=webrtc:6600
==========

to

==========
Follow standard sending CVO rtp header extension
Include CVO in key frame.
Include CVO in delta frame when rotation changes.
Include CVO when it is non zero to support current receiver implementation.

BUG=webrtc:6600
==========

[danilchap, 2016-10-25 14:35:39]

danilchap@webrtc.org changed reviewers:
- sprang@google.com

[danilchap, 2016-10-25 14:40:13]

On 2016/10/25 13:39:02, språng wrote:
>
https://codereview.webrtc.org/2452583002/diff/1/webrtc/modules/rtp_rtcp/sourc...
> File webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc (right):
> 
>
https://codereview.webrtc.org/2452583002/diff/1/webrtc/modules/rtp_rtcp/sourc...
> webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc:1497:
> EXPECT_EQ(kVideoRotation_90, rotation);
> There seems to be a bunch of code duplication between the test cases here. Can
> you create a subclass or helper class with the common bits?

Yes, all tests parse packets sent by RTPSender, it seems cleaner to move that
part to helper: https://codereview.webrtc.org/2447103002/

[sprang_webrtc, 2016-10-26 08:11:39]

lgtm
thanks!

[danilchap, 2016-10-26 10:03:15]

The CQ bit was checked by danilchap@webrtc.org

[danilchap, 2016-10-26 10:03:16]

The patchset sent to the CQ was uploaded after l-g-t-m from sprang@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2452583002/#ps40001 (title:
"-now unused helper")

[commit-bot: I haz the power, 2016-10-26 10:03:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-10-26 10:33:13]

Description was changed from

==========
Follow standard sending CVO rtp header extension
Include CVO in key frame.
Include CVO in delta frame when rotation changes.
Include CVO when it is non zero to support current receiver implementation.

BUG=webrtc:6600
==========

to

==========
Follow standard sending CVO rtp header extension
Include CVO in key frame.
Include CVO in delta frame when rotation changes.
Include CVO when it is non zero to support current receiver implementation.

BUG=webrtc:6600
==========

[commit-bot: I haz the power, 2016-10-26 10:33:14]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-26 10:33:23]

Description was changed from

==========
Follow standard sending CVO rtp header extension
Include CVO in key frame.
Include CVO in delta frame when rotation changes.
Include CVO when it is non zero to support current receiver implementation.

BUG=webrtc:6600
==========

to

==========
Follow standard sending CVO rtp header extension
Include CVO in key frame.
Include CVO in delta frame when rotation changes.
Include CVO when it is non zero to support current receiver implementation.

BUG=webrtc:6600

Committed: https://crrev.com/c1600c56959fcf25ca9e3a93342155d781c1bcd2
Cr-Commit-Position: refs/heads/master@{#14784}
==========

[commit-bot: I haz the power, 2016-10-26 10:33:24]

Patchset 3 (id:??) landed as
https://crrev.com/c1600c56959fcf25ca9e3a93342155d781c1bcd2
Cr-Commit-Position: refs/heads/master@{#14784}