RTCInboundRTPStreamStats added.

RTCInboundRTPStreamStats[1] added.

Not all stats are collected in this CL, this must be addressed before
closing the issue.

[1] https://w3c.github.io/webrtc-stats/#inboundrtpstats-dict*

BUG=chromium:627816, chromium:657855, chromium:657854
Committed: https://crrev.com/0d7bf169402ea9345d163998f4f7df89229ac470
Cr-Commit-Position: refs/heads/master@{#14861}

[hbos, 2016-10-26 12:39:41]

Patchset #1 (id:1) has been deleted

[hbos, 2016-10-26 12:41:21]

Description was changed from

==========
RTCInboundRTPStreamStats added.

BUG=
==========

to

==========
RTCInboundRTPStreamStats[1] added.

Not all stats are collected in this CL, this must be addressed before
closing the issue.

[1] https://w3c.github.io/webrtc-stats/#inboundrtpstats-dict*

BUG=chromium:627816, chromium:657855, chromium:657854
==========

[hbos, 2016-10-26 12:41:22]

hbos@webrtc.org changed reviewers:
+ deadbeef@webrtc.org, hta@webrtc.org

[hbos, 2016-10-26 12:45:59]

Please take a look, hta and deadbeef.

[hta-webrtc, 2016-10-27 12:39:27]

lgtm

[Taylor Brandstetter, 2016-10-27 21:26:03]

https://codereview.webrtc.org/2452043002/diff/20001/webrtc/api/rtcstatscollec...
File webrtc/api/rtcstatscollector.cc (right):

https://codereview.webrtc.org/2452043002/diff/20001/webrtc/api/rtcstatscollec...
webrtc/api/rtcstatscollector.cc:120:
static_cast<double>(voice_receiver_info.jitter_buffer_ms) /
I don't think this is right; it looks like jitter_buffer_ms is the delay used by
the jitter buffer, rather than the raw jitter. I think we want "jitter_ms". Same
below.

https://codereview.webrtc.org/2452043002/diff/20001/webrtc/api/rtcstatscollec...
webrtc/api/rtcstatscollector.cc:525: if (!transport_id.empty())
Is it ever possible for transport_id to be empty here?

https://codereview.webrtc.org/2452043002/diff/20001/webrtc/api/rtcstatscollec...
File webrtc/api/rtcstatscollector_unittest.cc (right):

https://codereview.webrtc.org/2452043002/diff/20001/webrtc/api/rtcstatscollec...
webrtc/api/rtcstatscollector_unittest.cc:1013:
channel_stats.connection_infos.push_back(connection_info);
Is this connection_info needed?

[Taylor Brandstetter, 2016-10-27 21:28:30]

https://codereview.webrtc.org/2452043002/diff/20001/webrtc/api/rtcstatscollec...
File webrtc/api/rtcstatscollector.cc (right):

https://codereview.webrtc.org/2452043002/diff/20001/webrtc/api/rtcstatscollec...
webrtc/api/rtcstatscollector.cc:525: if (!transport_id.empty())
On 2016/10/27 21:26:03, Taylor Brandstetter wrote:
> Is it ever possible for transport_id to be empty here?

Oh, I see now. It's possible given how "proxy_to_transport" works, but it's one
of those things that "shouldn't" ever happen. So I'd give it an RTC_DCHECK at
least.

[hbos, 2016-10-28 10:03:48]

PTAL deadbeef

https://codereview.webrtc.org/2452043002/diff/20001/webrtc/api/rtcstatscollec...
File webrtc/api/rtcstatscollector.cc (right):

https://codereview.webrtc.org/2452043002/diff/20001/webrtc/api/rtcstatscollec...
webrtc/api/rtcstatscollector.cc:120:
static_cast<double>(voice_receiver_info.jitter_buffer_ms) /
On 2016/10/27 21:26:03, Taylor Brandstetter wrote:
> I don't think this is right; it looks like jitter_buffer_ms is the delay used
by
> the jitter buffer, rather than the raw jitter. I think we want "jitter_ms".
Same
> below.

Done. The audio case has jitter_ms, jitter_buffer_ms and
jitter_buffer_preferred_ms but the video case only has jitter_buffer_ms (with
comment "Jitter (network-related) latency").
I updated to use jitter_ms in the audio case and skipped the stat for the video
case.

https://codereview.webrtc.org/2452043002/diff/20001/webrtc/api/rtcstatscollec...
webrtc/api/rtcstatscollector.cc:525: if (!transport_id.empty())
On 2016/10/27 21:28:30, Taylor Brandstetter wrote:
> On 2016/10/27 21:26:03, Taylor Brandstetter wrote:
> > Is it ever possible for transport_id to be empty here?
> 
> Oh, I see now. It's possible given how "proxy_to_transport" works, but it's
one
> of those things that "shouldn't" ever happen. So I'd give it an RTC_DCHECK at
> least.

Done.

https://codereview.webrtc.org/2452043002/diff/20001/webrtc/api/rtcstatscollec...
File webrtc/api/rtcstatscollector_unittest.cc (right):

https://codereview.webrtc.org/2452043002/diff/20001/webrtc/api/rtcstatscollec...
webrtc/api/rtcstatscollector_unittest.cc:1013:
channel_stats.connection_infos.push_back(connection_info);
On 2016/10/27 21:26:03, Taylor Brandstetter wrote:
> Is this connection_info needed?

Ah, it isn't, removed here and other places.

[Taylor Brandstetter, 2016-10-28 19:34:12]

lgtm

[hbos, 2016-10-31 22:00:31]

The CQ bit was checked by hbos@webrtc.org

[hbos, 2016-10-31 22:00:31]

The patchset sent to the CQ was uploaded after l-g-t-m from hta@webrtc.org,
deadbeef@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2452043002/#ps80001 (title:
"Rebase with master after CL this depends on landed")

[commit-bot: I haz the power, 2016-10-31 22:00:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[hbos, 2016-10-31 22:02:22]

The CQ bit was unchecked by hbos@webrtc.org

[hbos, 2016-10-31 22:02:42]

Patchset #4 (id:80001) has been deleted

[hbos, 2016-10-31 22:02:45]

The CQ bit was checked by hbos@webrtc.org

[hbos, 2016-10-31 22:02:46]

The patchset sent to the CQ was uploaded after l-g-t-m from hta@webrtc.org,
deadbeef@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2452043002/#ps100001 (title:
"Rebase with master after CL this depends on landed")

[commit-bot: I haz the power, 2016-10-31 22:02:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-10-31 22:31:05]

Description was changed from

==========
RTCInboundRTPStreamStats[1] added.

Not all stats are collected in this CL, this must be addressed before
closing the issue.

[1] https://w3c.github.io/webrtc-stats/#inboundrtpstats-dict*

BUG=chromium:627816, chromium:657855, chromium:657854
==========

to

==========
RTCInboundRTPStreamStats[1] added.

Not all stats are collected in this CL, this must be addressed before
closing the issue.

[1] https://w3c.github.io/webrtc-stats/#inboundrtpstats-dict*

BUG=chromium:627816, chromium:657855, chromium:657854
==========

[commit-bot: I haz the power, 2016-10-31 22:31:06]

Committed patchset #4 (id:100001)

[commit-bot: I haz the power, 2016-10-31 22:31:14]

Description was changed from

==========
RTCInboundRTPStreamStats[1] added.

Not all stats are collected in this CL, this must be addressed before
closing the issue.

[1] https://w3c.github.io/webrtc-stats/#inboundrtpstats-dict*

BUG=chromium:627816, chromium:657855, chromium:657854
==========

to

==========
RTCInboundRTPStreamStats[1] added.

Not all stats are collected in this CL, this must be addressed before
closing the issue.

[1] https://w3c.github.io/webrtc-stats/#inboundrtpstats-dict*

BUG=chromium:627816, chromium:657855, chromium:657854

Committed: https://crrev.com/0d7bf169402ea9345d163998f4f7df89229ac470
Cr-Commit-Position: refs/heads/master@{#14861}
==========

[commit-bot: I haz the power, 2016-10-31 22:31:15]

Patchset 4 (id:??) landed as
https://crrev.com/0d7bf169402ea9345d163998f4f7df89229ac470
Cr-Commit-Position: refs/heads/master@{#14861}

[perkj_webrtc, 2016-11-01 06:50:44]

A revert of this CL (patchset #4 id:100001) has been created in
https://codereview.webrtc.org/2470683002/ by perkj@webrtc.org.

The reason for reverting is: Dependend cl Breaks Chrome FYI. 
peerconnection_unittest anropar RTCStatsReport::Create without  parameters..