Check that stats_proxy_ is non-NULL before use.

Check that stats_proxy_ is non-NULL before use.

BUG=None

Committed: https://crrev.com/784a83122bc837cbed500d6295b4b45f8fe6a7be
Cr-Commit-Position: refs/heads/master@{#14788}

[nisse-webrtc, 2016-10-26 11:06:45]

nisse@webrtc.org changed reviewers:
+ stefan@webrtc.org

[nisse-webrtc, 2016-10-26 11:06:45]

All other uses of stats_proxy_ methods check for NULL.

[stefan-webrtc, 2016-10-26 11:12:06]

When will it be null? Shouldn't we pass in an instance in that case?

[nisse-webrtc, 2016-10-26 11:29:29]

On 2016/10/26 11:12:06, stefan-webrtc (holmer) wrote:
> When will it be null? Shouldn't we pass in an instance in that case?

I pass in nullptr to the constructor in my quartc test code, since I don't think
I have any use for a stats proxy. It seems it is treated as optional in the rest
of the class, but it crashes at this call because the pointer is unconditionally
dereferenced.

[stefan-webrtc, 2016-10-26 11:34:19]

Thanks, lgtm!

[nisse-webrtc, 2016-10-26 13:07:04]

The CQ bit was checked by nisse@webrtc.org

[commit-bot: I haz the power, 2016-10-26 13:07:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-10-26 14:02:25]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-26 14:02:33]

Description was changed from

==========
Check that stats_proxy_ is non-NULL before use.

BUG=None
==========

to

==========
Check that stats_proxy_ is non-NULL before use.

BUG=None

Committed: https://crrev.com/784a83122bc837cbed500d6295b4b45f8fe6a7be
Cr-Commit-Position: refs/heads/master@{#14788}
==========

[commit-bot: I haz the power, 2016-10-26 14:02:34]

Patchset 1 (id:??) landed as
https://crrev.com/784a83122bc837cbed500d6295b4b45f8fe6a7be
Cr-Commit-Position: refs/heads/master@{#14788}