Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2450983002: Do not rely on specific ordering on generated candidates in TestGetAllPortsPortRange (Closed)

Created:
4 years, 1 month ago by honghaiz3
Modified:
4 years, 1 month ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Do not rely on specific ordering on generated candidates in TestGetAllPortsPortRange This fixes another WebRTC swarming tests. BUG=webrtc:6500 Committed: https://crrev.com/a73df559d63b74acc1aeb8d9a4a8d26af6e6c6db Cr-Commit-Position: refs/heads/master@{#14804}

Patch Set 1 : . #

Total comments: 2

Patch Set 2 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -6 lines) Patch
M webrtc/p2p/client/basicportallocator_unittest.cc View 1 1 chunk +10 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Taylor Brandstetter
lgtm. Though I think the description/title should be changed to "Don't rely on a specific ...
4 years, 1 month ago (2016-10-27 16:54:09 UTC) #4
honghaiz3
https://codereview.webrtc.org/2450983002/diff/20001/webrtc/p2p/client/basicportallocator_unittest.cc File webrtc/p2p/client/basicportallocator_unittest.cc (right): https://codereview.webrtc.org/2450983002/diff/20001/webrtc/p2p/client/basicportallocator_unittest.cc#newcode926 webrtc/p2p/client/basicportallocator_unittest.cc:926: // Check the port number for the UDP/STUN/TCP port ...
4 years, 1 month ago (2016-10-27 17:31:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2450983002/40001
4 years, 1 month ago (2016-10-27 17:32:17 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 1 month ago (2016-10-27 18:44:20 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-10-27 19:01:48 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a73df559d63b74acc1aeb8d9a4a8d26af6e6c6db
Cr-Commit-Position: refs/heads/master@{#14804}

Powered by Google App Engine
This is Rietveld 408576698