Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Issue 2450743002: codec_unittest.cc: Fix TEST vs TEST_F mismatch (Closed)

Created:
4 years, 1 month ago by magjed_webrtc
Modified:
4 years, 1 month ago
Reviewers:
the sun, kthelgason
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

codec_unittest.cc: Fix TEST vs TEST_F mismatch This CL fixes a typo introduced in "Revert of H264 codec: Check profile-level-id when matching" https://codereview.webrtc.org/2440123002/. BUG=NONE TBR=kthelgason Committed: https://chromium.googlesource.com/external/webrtc/+/dbf6705895c79312f4b5c28eeddd42110a4f56ad

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M webrtc/media/base/codec_unittest.cc View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 8 (5 generated)
magjed_webrtc
Committed patchset #1 (id:1) manually as dbf6705895c79312f4b5c28eeddd42110a4f56ad (presubmit successful).
4 years, 1 month ago (2016-10-25 08:17:56 UTC) #5
the sun
https://codereview.webrtc.org/2450743002/diff/1/webrtc/media/base/codec_unittest.cc File webrtc/media/base/codec_unittest.cc (right): https://codereview.webrtc.org/2450743002/diff/1/webrtc/media/base/codec_unittest.cc#newcode186 webrtc/media/base/codec_unittest.cc:186: TEST_F(CodecTest, TestDataCodecMatches) { Note: avoid fixtures if not needed, ...
4 years, 1 month ago (2016-10-25 08:40:39 UTC) #7
kthelgason
4 years, 1 month ago (2016-10-25 11:31:16 UTC) #8
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698