Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2450363003: Add unit tests to ReceiveStatisticsProxy class. (Closed)

Created:
4 years, 1 month ago by åsapersson
Modified:
4 years, 1 month ago
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add unit tests to ReceiveStatisticsProxy class. BUG=none Committed: https://crrev.com/46c4e3caa32f1d46f681455ae6e401a96d33b529 Cr-Commit-Position: refs/heads/master@{#14911}

Patch Set 1 : tests moved from https://codereview.webrtc.org/2385763002 #

Patch Set 2 #

Total comments: 2

Patch Set 3 : add comments #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -0 lines) Patch
M webrtc/video/receive_statistics_proxy_unittest.cc View 1 2 3 3 chunks +74 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
åsapersson
4 years, 1 month ago (2016-10-28 10:43:09 UTC) #3
stefan-webrtc
https://codereview.webrtc.org/2450363003/diff/20001/webrtc/video/receive_statistics_proxy_unittest.cc File webrtc/video/receive_statistics_proxy_unittest.cc (right): https://codereview.webrtc.org/2450363003/diff/20001/webrtc/video/receive_statistics_proxy_unittest.cc#newcode106 webrtc/video/receive_statistics_proxy_unittest.cc:106: statistics_proxy_.reset(); Why reset here? Maybe comment on that.
4 years, 1 month ago (2016-10-31 09:45:42 UTC) #4
åsapersson
https://codereview.webrtc.org/2450363003/diff/20001/webrtc/video/receive_statistics_proxy_unittest.cc File webrtc/video/receive_statistics_proxy_unittest.cc (right): https://codereview.webrtc.org/2450363003/diff/20001/webrtc/video/receive_statistics_proxy_unittest.cc#newcode106 webrtc/video/receive_statistics_proxy_unittest.cc:106: statistics_proxy_.reset(); On 2016/10/31 09:45:42, stefan-webrtc (holmer) wrote: > Why ...
4 years, 1 month ago (2016-10-31 10:20:25 UTC) #5
sprang_webrtc
lgtm
4 years, 1 month ago (2016-10-31 15:34:38 UTC) #6
stefan-webrtc
lgtm
4 years, 1 month ago (2016-11-03 13:43:18 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2450363003/80001
4 years, 1 month ago (2016-11-03 13:47:05 UTC) #11
commit-bot: I haz the power
Committed patchset #4 (id:80001)
4 years, 1 month ago (2016-11-03 13:48:21 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-11-03 13:48:43 UTC) #15
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/46c4e3caa32f1d46f681455ae6e401a96d33b529
Cr-Commit-Position: refs/heads/master@{#14911}

Powered by Google App Engine
This is Rietveld 408576698