webrtc/media/engine/webrtcvideoengine2.h - Issue 2449993003: Replace WebRtcVideoEncoderFactory::VideoCodec with cricket::VideoCodec

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/media/engine/webrtcvideoengine2.h

Issue 2449993003: Replace WebRtcVideoEncoderFactory::VideoCodec with cricket::VideoCodec (Closed)

Patch Set: Compare only codec names, not VideoCodec::Matches Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/media/engine/webrtcvideoengine2.h

diff --git a/webrtc/media/engine/webrtcvideoengine2.h b/webrtc/media/engine/webrtcvideoengine2.h

index 716390557cd4497198ef9028f3b1535c0cdfd183..263e834a95b51571ae306ab9900a829601de419d 100644

--- a/webrtc/media/engine/webrtcvideoengine2.h

+++ b/webrtc/media/engine/webrtcvideoengine2.h

@@ -119,8 +119,6 @@ class WebRtcVideoEngine2 {

WebRtcVideoEncoderFactory* encoder_factory);

private:

- std::vector<VideoCodec> GetSupportedCodecs() const;

std::vector<VideoCodec> video_codecs_;

bool initialized_;

@@ -226,7 +224,6 @@ class WebRtcVideoChannel2 : public VideoMediaChannel, public webrtc::Transport {

void ConfigureReceiverRtp(webrtc::VideoReceiveStream::Config* config,

const StreamParams& sp) const;

- bool CodecIsExternallySupported(const std::string& name) const;

bool ValidateSendSsrcAvailability(const StreamParams& sp) const

EXCLUSIVE_LOCKS_REQUIRED(stream_crit_);

bool ValidateReceiveSsrcAvailability(const StreamParams& sp) const