Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 2449783002: Rename ProducerFec to UlpfecGenerator. (Closed)

Created:
4 years, 1 month ago by brandtr
Modified:
4 years, 1 month ago
Reviewers:
stefan-webrtc
CC:
danilchap, webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, stefan-webrtc, mflodman, fuzzing_chromiuim.org
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Rename ProducerFec to UlpfecGenerator. BUG=webrtc:5654 Committed: https://crrev.com/869e7cd8e789b2460f8456ec4acb1fc2eed2a38c Cr-Commit-Position: refs/heads/master@{#14847}

Patch Set 1 : Rename files. #

Patch Set 2 : Update code and run 'git cl format'. #

Patch Set 3 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -711 lines) Patch
M webrtc/modules/BUILD.gn View 1 2 2 chunks +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/BUILD.gn View 1 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/rtp_rtcp.gypi View 1 2 chunks +2 lines, -2 lines 0 comments Download
D webrtc/modules/rtp_rtcp/source/producer_fec.h View 1 chunk +0 lines, -109 lines 0 comments Download
D webrtc/modules/rtp_rtcp/source/producer_fec.cc View 1 chunk +0 lines, -251 lines 0 comments Download
D webrtc/modules/rtp_rtcp/source/producer_fec_unittest.cc View 1 chunk +0 lines, -203 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender_video.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender_video.cc View 1 2 5 chunks +9 lines, -10 lines 0 comments Download
A + webrtc/modules/rtp_rtcp/source/ulpfec_generator.h View 1 3 chunks +6 lines, -6 lines 0 comments Download
A + webrtc/modules/rtp_rtcp/source/ulpfec_generator.cc View 1 10 chunks +17 lines, -20 lines 0 comments Download
A + webrtc/modules/rtp_rtcp/source/ulpfec_generator_unittest.cc View 1 9 chunks +33 lines, -32 lines 0 comments Download
M webrtc/test/fuzzers/BUILD.gn View 1 1 chunk +2 lines, -2 lines 0 comments Download
D webrtc/test/fuzzers/producer_fec_fuzzer.cc View 1 chunk +0 lines, -62 lines 0 comments Download
A + webrtc/test/fuzzers/ulpfec_generator_fuzzer.cc View 1 3 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
brandtr
Update code + 'git cl format'.
4 years, 1 month ago (2016-10-25 07:29:35 UTC) #1
brandtr
4 years, 1 month ago (2016-10-25 07:43:22 UTC) #3
brandtr
Rebase.
4 years, 1 month ago (2016-10-28 07:42:08 UTC) #5
stefan-webrtc
lgtm
4 years, 1 month ago (2016-10-31 09:12:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2449783002/40001
4 years, 1 month ago (2016-10-31 11:46:58 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-10-31 12:27:10 UTC) #10
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/869e7cd8e789b2460f8456ec4acb1fc2eed2a38c Cr-Commit-Position: refs/heads/master@{#14847}
4 years, 1 month ago (2016-10-31 12:27:19 UTC) #12
mmoroz
On 2016/10/31 12:27:19, commit-bot: I haz the power wrote: > Patchset 3 (id:??) landed as ...
4 years, 1 month ago (2016-11-11 12:21:45 UTC) #13
brandtr
On 2016/11/11 12:21:45, mmoroz wrote: > On 2016/10/31 12:27:19, commit-bot: I haz the power wrote: ...
4 years, 1 month ago (2016-11-11 13:44:27 UTC) #15
mmoroz
4 years, 1 month ago (2016-11-11 14:12:13 UTC) #16
Message was sent while issue was closed.
On 2016/11/11 13:44:27, brandtr wrote:
> On 2016/11/11 12:21:45, mmoroz wrote:
> > On 2016/10/31 12:27:19, commit-bot: I haz the power wrote:
> > > Patchset 3 (id:??) landed as
> > > https://crrev.com/869e7cd8e789b2460f8456ec4acb1fc2eed2a38c
> > > Cr-Commit-Position: refs/heads/master@{#14847}
> > 
> > Since the fuzzer has been remaned, we need to rename its corpus directory in
> the
> > cloud. Please confirm that old corpus is still valid, so I'll rename old one
> > (actually will merge old one into a new directory created automatically for
a
> > new name).
> 
> Yes, old corpus is still valid. This is a pure rename. Thanks!

Done. Sadly, it didn't improve the coverage :( and performance analysis says
that lack of NEW units is a top problem for that fuzzer. Can we give it some
seed corpus? At lest couple units would be very helpful.

Powered by Google App Engine
This is Rietveld 408576698