Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Issue 2449693003: Fix a deadlock in EglRenderer.releaseEglSurface. (Closed)

Created:
4 years, 1 month ago by sakal
Modified:
4 years, 1 month ago
Reviewers:
magjed_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix a deadlock in EglRenderer.releaseEglSurface. Main thread is waiting for an operation on the render thread to complete while holding the handler lock. Something can be waiting on the render thread for this lock. This CL changes the behaviour so that the lock is released before waiting for the operation to complete. BUG=webrtc:6602, webrtc:6470 R=magjed@webrtc.org Committed: https://crrev.com/d0af5c6fd46d9248113a4c5f0e0fc54c9671b394 Cr-Commit-Position: refs/heads/master@{#14773}

Patch Set 1 : Fix bug #

Patch Set 2 : Oops, fix another bug. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M webrtc/api/android/java/src/org/webrtc/EglRenderer.java View 1 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
sakal
PTAL
4 years, 1 month ago (2016-10-25 12:01:36 UTC) #1
magjed_webrtc
lgtm
4 years, 1 month ago (2016-10-25 12:40:12 UTC) #5
magjed_webrtc
Add reference to issue webrtc:6470 as well.
4 years, 1 month ago (2016-10-25 12:41:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2449693003/80001
4 years, 1 month ago (2016-10-25 13:47:59 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:80001)
4 years, 1 month ago (2016-10-25 14:20:55 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-10-25 14:21:08 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d0af5c6fd46d9248113a4c5f0e0fc54c9671b394
Cr-Commit-Position: refs/heads/master@{#14773}

Powered by Google App Engine
This is Rietveld 408576698