Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 2449523002: Revert of Fix chromium-style warnings. (Closed)

Created:
4 years, 1 month ago by terelius
Modified:
4 years, 1 month ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, danilchap, stefan-webrtc, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Fix chromium-style warnings. (patchset #1 id:1 of https://codereview.webrtc.org/2400993002/ ) Reason for revert: Broke internal project Original issue's description: > Fix chromium-style warnings. > > Separate the null implementation from rtp_rtcp_defines.h, and follow chromium style guide for virtual functions. > > BUG=webrtc:163 > > Committed: https://crrev.com/509eadd554de6bf938da08071c5d2c2541703134 > Cr-Commit-Position: refs/heads/master@{#14738} TBR=danilchap@webrtc.org,kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:163 Committed: https://crrev.com/838cdb3db6a24b9be3a3d2700144197935415463 Cr-Commit-Position: refs/heads/master@{#14750}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -94 lines) Patch
M webrtc/modules/rtp_rtcp/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/include/rtp_rtcp_defines.h View 1 chunk +33 lines, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/rtp_rtcp.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/fec_receiver_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/nack_rtx_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_sender_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
D webrtc/modules/rtp_rtcp/source/rtp_rtcp_defines_nullimpl.h View 1 chunk +0 lines, -49 lines 0 comments Download
D webrtc/modules/rtp_rtcp/source/rtp_rtcp_defines_nullimpl.cc View 1 chunk +0 lines, -35 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_utility.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/test/testAPI/test_api.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
terelius
Created Revert of Fix chromium-style warnings.
4 years, 1 month ago (2016-10-24 16:38:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2449523002/1
4 years, 1 month ago (2016-10-24 16:38:16 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-24 16:38:26 UTC) #4
commit-bot: I haz the power
4 years, 1 month ago (2016-10-24 16:50:09 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/838cdb3db6a24b9be3a3d2700144197935415463
Cr-Commit-Position: refs/heads/master@{#14750}

Powered by Google App Engine
This is Rietveld 408576698