Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Unified Diff: webrtc/modules/rtp_rtcp/source/rtp_sender_video.h

Issue 2448463003: Rename {,Set}GenericFECStatus to {,Set}UlpfecConfig. (Closed)
Patch Set: Feedback response 1 and lint fix. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/rtp_rtcp/source/rtp_sender_video.h
diff --git a/webrtc/modules/rtp_rtcp/source/rtp_sender_video.h b/webrtc/modules/rtp_rtcp/source/rtp_sender_video.h
index 96ddf4192141cfa1aedaea3d891d3c97c2de842a..60fbb68caea65628066271bdc5c13419203ae41a 100644
--- a/webrtc/modules/rtp_rtcp/source/rtp_sender_video.h
+++ b/webrtc/modules/rtp_rtcp/source/rtp_sender_video.h
@@ -59,13 +59,13 @@ class RTPSenderVideo {
void SetVideoCodecType(RtpVideoCodecTypes type);
// FEC
- void SetGenericFECStatus(bool enable,
- uint8_t payload_type_red,
- uint8_t payload_type_fec);
+ void SetUlpfecConfig(bool enabled,
+ int red_payload_type,
+ int ulpfec_payload_type);
- void GenericFECStatus(bool* enable,
- uint8_t* payload_type_red,
- uint8_t* payload_type_fec) const;
+ void UlpfecConfig(bool* enabled,
+ int* red_payload_type,
+ int* ulpfec_payload_type) const;
void SetFecParameters(const FecProtectionParams* delta_params,
const FecProtectionParams* key_params);
@@ -95,8 +95,8 @@ class RTPSenderVideo {
// FEC
bool fec_enabled_ GUARDED_BY(crit_) = false;
- int8_t red_payload_type_ GUARDED_BY(crit_) = 0;
- int8_t fec_payload_type_ GUARDED_BY(crit_) = 0;
+ int red_payload_type_ GUARDED_BY(crit_) = -1;
+ int fec_payload_type_ GUARDED_BY(crit_) = -1;
FecProtectionParams delta_fec_params_ GUARDED_BY(crit_) = FecProtectionParams{
0, 1, kFecMaskRandom};
FecProtectionParams key_fec_params_ GUARDED_BY(crit_) = FecProtectionParams{

Powered by Google App Engine
This is Rietveld 408576698