Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: webrtc/modules/rtp_rtcp/source/rtp_sender_video.h

Issue 2448463003: Rename {,Set}GenericFECStatus to {,Set}UlpfecConfig. (Closed)
Patch Set: Feedback response 3. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/rtp_rtcp/source/rtp_sender_video.h
diff --git a/webrtc/modules/rtp_rtcp/source/rtp_sender_video.h b/webrtc/modules/rtp_rtcp/source/rtp_sender_video.h
index f69b8e370a56843a98dac597ebad5519183ed59f..1fe8a5ee014c0b225e7ff5e6a655d6a2c6264df9 100644
--- a/webrtc/modules/rtp_rtcp/source/rtp_sender_video.h
+++ b/webrtc/modules/rtp_rtcp/source/rtp_sender_video.h
@@ -60,13 +60,13 @@ class RTPSenderVideo {
void SetVideoCodecType(RtpVideoCodecTypes type);
// FEC
- void SetGenericFECStatus(bool enable,
- uint8_t payload_type_red,
- uint8_t payload_type_fec);
+ void SetUlpfecConfig(bool enabled,
+ int red_payload_type,
+ int ulpfec_payload_type);
- void GenericFECStatus(bool* enable,
- uint8_t* payload_type_red,
- uint8_t* payload_type_fec) const;
+ void GetUlpfecConfig(bool* enabled,
+ int* red_payload_type,
+ int* ulpfec_payload_type) const;
void SetFecParameters(const FecProtectionParams* delta_params,
const FecProtectionParams* key_params);
@@ -92,18 +92,16 @@ class RTPSenderVideo {
rtc::CriticalSection crit_;
rtc::SequencedTaskChecker encoder_checker_;
- RtpVideoCodecTypes video_type_ = kRtpVideoGeneric;
- int32_t retransmission_settings_ GUARDED_BY(crit_) = kRetransmitBaseLayer;
- VideoRotation last_rotation_ GUARDED_BY(encoder_checker_) = kVideoRotation_0;
+ RtpVideoCodecTypes video_type_;
+ int32_t retransmission_settings_ GUARDED_BY(crit_);
+ VideoRotation last_rotation_ GUARDED_BY(encoder_checker_);
// FEC
- bool fec_enabled_ GUARDED_BY(crit_) = false;
- int8_t red_payload_type_ GUARDED_BY(crit_) = 0;
- int8_t fec_payload_type_ GUARDED_BY(crit_) = 0;
- FecProtectionParams delta_fec_params_ GUARDED_BY(crit_) = FecProtectionParams{
- 0, 1, kFecMaskRandom};
- FecProtectionParams key_fec_params_ GUARDED_BY(crit_) = FecProtectionParams{
- 0, 1, kFecMaskRandom};
+ bool fec_enabled_ GUARDED_BY(crit_);
+ int red_payload_type_ GUARDED_BY(crit_);
+ int fec_payload_type_ GUARDED_BY(crit_);
+ FecProtectionParams delta_fec_params_ GUARDED_BY(crit_);
+ FecProtectionParams key_fec_params_ GUARDED_BY(crit_);
ProducerFec producer_fec_ GUARDED_BY(crit_);
rtc::CriticalSection stats_crit_;

Powered by Google App Engine
This is Rietveld 408576698