Rename {,Set}GenericFECStatus to {,Set}UlpfecConfig.

webrtc/modules/rtp_rtcp/source/rtp_sender_video.h

Index: webrtc/modules/rtp_rtcp/source/rtp_sender_video.h
diff --git a/webrtc/modules/rtp_rtcp/source/rtp_sender_video.h b/webrtc/modules/rtp_rtcp/source/rtp_sender_video.h
index f69b8e370a56843a98dac597ebad5519183ed59f..16c49a0f566f66f097386677455c27564b1a57d1 100644
--- a/webrtc/modules/rtp_rtcp/source/rtp_sender_video.h
+++ b/webrtc/modules/rtp_rtcp/source/rtp_sender_video.h
@@ -60,13 +60,13 @@ class RTPSenderVideo {
   void SetVideoCodecType(RtpVideoCodecTypes type);
 
   // FEC
-  void SetGenericFECStatus(bool enable,
-                           uint8_t payload_type_red,
-                           uint8_t payload_type_fec);
+  void SetUlpfecConfig(bool enabled,
+                       int red_payload_type,
+                       int ulpfec_payload_type);
 
-  void GenericFECStatus(bool* enable,
-                        uint8_t* payload_type_red,
-                        uint8_t* payload_type_fec) const;
+  void UlpfecConfig(bool* enabled,

[stefan-webrtc, 2016/10/31 09:33:16]

Perhaps GetUlpfecConfig

[brandtr, 2016/10/31 12:47:03]

Done.

+                    int* red_payload_type,
+                    int* ulpfec_payload_type) const;
 
   void SetFecParameters(const FecProtectionParams* delta_params,
                         const FecProtectionParams* key_params);
@@ -98,8 +98,8 @@ class RTPSenderVideo {
 
   // FEC
   bool fec_enabled_ GUARDED_BY(crit_) = false;
-  int8_t red_payload_type_ GUARDED_BY(crit_) = 0;
-  int8_t fec_payload_type_ GUARDED_BY(crit_) = 0;
+  int red_payload_type_ GUARDED_BY(crit_) = -1;
+  int fec_payload_type_ GUARDED_BY(crit_) = -1;

[stefan-webrtc, 2016/10/31 09:33:16]

I'd prefer moving these initializations to the initializer list. Feel free to do
that...

[brandtr, 2016/10/31 12:47:03]

Done!

This was originally my plan, but then I saw this CL:
https://codereview.webrtc.org/2067673004/diff/200001/webrtc/modules/rtp_rtcp/...

But with your mandate, I'm happy to do this :)

[danilchap, 2016/10/31 13:22:00]

just curious, what are benefits of initializer list over default Member
Initializers?
Default member initializers make it easier to add new member, reorder existent
members, make it easier to see when a POD member miss initial value.

[stefan-webrtc, 2016/11/03 13:52:25]

We discussed this a lot at some point, and I think the conclusion was that it
harms readability if some members are initialized in the initializer list while
others are initialized in the .h file. At that point I remember that there
wasn't a clear consensus on whether this also would apply for const variables,
but I tend to just prefer everything in initializer lists to keep it simple.

Feel free to bring it up for discussion again if you think it's wrong though!

   FecProtectionParams delta_fec_params_ GUARDED_BY(crit_) = FecProtectionParams{
       0, 1, kFecMaskRandom};
   FecProtectionParams key_fec_params_ GUARDED_BY(crit_) = FecProtectionParams{