Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 2448393003: Remove deprecated methods from CameraEnumerationAndroid. (Closed)

Created:
4 years, 1 month ago by sakal
Modified:
4 years, 1 month ago
Reviewers:
magjed_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove deprecated methods from CameraEnumerationAndroid. Following methods are removed: getDeviceNames getDeviceCount getDeviceName(index) getNameOfFrontFacingDevice getNameOfBackFacingDevice BUG=webrtc:6606, webrtc:5519 Committed: https://crrev.com/b6e857d30b9ad9348303bcbac0c67a4a8f384606 Cr-Commit-Position: refs/heads/master@{#14966}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -66 lines) Patch
M webrtc/api/android/java/src/org/webrtc/Camera1Enumerator.java View 3 chunks +3 lines, -5 lines 0 comments Download
M webrtc/api/android/java/src/org/webrtc/CameraEnumerationAndroid.java View 3 chunks +0 lines, -61 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
sakal
PTAL
4 years, 1 month ago (2016-10-26 07:34:32 UTC) #3
magjed_webrtc
lgtm. Don't we have any bigger tracking issue than 6606? Isn't this work part of ...
4 years, 1 month ago (2016-10-26 11:26:18 UTC) #4
sakal
No these issues are not related. These methods are left over from the old refactoring ...
4 years, 1 month ago (2016-10-26 11:34:37 UTC) #5
magjed_webrtc
On 2016/10/26 11:34:37, sakal wrote: > No these issues are not related. These methods are ...
4 years, 1 month ago (2016-10-26 12:43:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2448393003/1
4 years, 1 month ago (2016-11-07 15:41:56 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_dbg/builds/12827) win_rel on master.tryserver.webrtc (JOB_FAILED, ...
4 years, 1 month ago (2016-11-07 18:04:52 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2448393003/1
4 years, 1 month ago (2016-11-08 09:50:31 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-08 10:06:41 UTC) #15
commit-bot: I haz the power
4 years, 1 month ago (2016-11-08 10:06:47 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b6e857d30b9ad9348303bcbac0c67a4a8f384606
Cr-Commit-Position: refs/heads/master@{#14966}

Powered by Google App Engine
This is Rietveld 408576698