Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(888)

Issue 2448053003: Fix out_frame argument of PreprocessFrameAndVerify. (Closed)

Created:
4 years, 1 month ago by nisse-webrtc
Modified:
4 years, 1 month ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix out_frame argument of PreprocessFrameAndVerify. Probably broken since https://codereview.webrtc.org/1482913003, making VideoProcessingTest.Resampler skip the PSNR checks. BUG=webrtc:5259 Committed: https://crrev.com/c846f2f4c044b8b206ac364530535c4d9ccf697a Cr-Commit-Position: refs/heads/master@{#14852}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -15 lines) Patch
M webrtc/modules/video_processing/test/video_processing_unittest.cc View 6 chunks +15 lines, -15 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
nisse-webrtc
4 years, 1 month ago (2016-10-25 09:53:01 UTC) #3
magjed_webrtc
lgtm
4 years, 1 month ago (2016-10-25 10:03:30 UTC) #4
nisse-webrtc
Stefan, can you have a look, since Magnus is ooo?
4 years, 1 month ago (2016-10-27 12:11:13 UTC) #6
stefan-webrtc
lgtm
4 years, 1 month ago (2016-10-31 13:59:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2448053003/1
4 years, 1 month ago (2016-10-31 14:00:32 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-31 14:20:48 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-10-31 14:21:00 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c846f2f4c044b8b206ac364530535c4d9ccf697a
Cr-Commit-Position: refs/heads/master@{#14852}

Powered by Google App Engine
This is Rietveld 408576698