Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 2447723002: Remove use of VoECodec in video/call tests. (Closed)

Created:
4 years, 1 month ago by the sun
Modified:
4 years, 1 month ago
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove use of VoECodec in video/call tests. BUG=webrtc:4690 Committed: https://crrev.com/68e6bdd970b7a85eccbead410f825c19cb0e97e6 Cr-Commit-Position: refs/heads/master@{#14797}

Patch Set 1 #

Patch Set 2 : android build error #

Total comments: 5

Patch Set 3 : comments #

Patch Set 4 : sign #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -31 lines) Patch
M webrtc/call/call_perf_tests.cc View 1 4 chunks +2 lines, -8 lines 0 comments Download
M webrtc/test/call_test.h View 2 chunks +0 lines, -3 lines 0 comments Download
M webrtc/test/call_test.cc View 1 2 3 7 chunks +4 lines, -11 lines 0 comments Download
M webrtc/video/video_quality_test.cc View 1 6 chunks +2 lines, -9 lines 0 comments Download

Messages

Total messages: 21 (8 generated)
the sun
4 years, 1 month ago (2016-10-24 14:58:35 UTC) #2
the sun
4 years, 1 month ago (2016-10-26 09:00:31 UTC) #4
sprang_webrtc
https://codereview.webrtc.org/2447723002/diff/20001/webrtc/test/call_test.cc File webrtc/test/call_test.cc (right): https://codereview.webrtc.org/2447723002/diff/20001/webrtc/test/call_test.cc#newcode204 webrtc/test/call_test.cc:204: CodecInst{kAudioSendPayloadType, "ISAC", 16000, 480, 1, 32000}; How is this ...
4 years, 1 month ago (2016-10-26 09:11:11 UTC) #5
the sun
https://codereview.webrtc.org/2447723002/diff/20001/webrtc/test/call_test.cc File webrtc/test/call_test.cc (right): https://codereview.webrtc.org/2447723002/diff/20001/webrtc/test/call_test.cc#newcode204 webrtc/test/call_test.cc:204: CodecInst{kAudioSendPayloadType, "ISAC", 16000, 480, 1, 32000}; On 2016/10/26 09:11:10, ...
4 years, 1 month ago (2016-10-26 09:22:48 UTC) #6
sprang_webrtc
lgtm https://codereview.webrtc.org/2447723002/diff/20001/webrtc/test/call_test.cc File webrtc/test/call_test.cc (right): https://codereview.webrtc.org/2447723002/diff/20001/webrtc/test/call_test.cc#newcode204 webrtc/test/call_test.cc:204: CodecInst{kAudioSendPayloadType, "ISAC", 16000, 480, 1, 32000}; On 2016/10/26 ...
4 years, 1 month ago (2016-10-26 09:30:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2447723002/60001
4 years, 1 month ago (2016-10-26 12:01:16 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/9563)
4 years, 1 month ago (2016-10-26 12:03:41 UTC) #12
the sun
Stefan, could you give OWNERs lgtm?
4 years, 1 month ago (2016-10-26 12:33:51 UTC) #14
the sun
On 2016/10/26 12:33:51, the sun wrote: > Stefan, could you give OWNERs lgtm? ping...
4 years, 1 month ago (2016-10-26 20:27:43 UTC) #15
stefan-webrtc
Sorry for the delay! Very nice to see this cleaned up :) lgtm
4 years, 1 month ago (2016-10-27 06:56:57 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2447723002/60001
4 years, 1 month ago (2016-10-27 07:21:51 UTC) #18
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 1 month ago (2016-10-27 07:23:10 UTC) #19
commit-bot: I haz the power
4 years, 1 month ago (2016-10-27 07:23:20 UTC) #21
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/68e6bdd970b7a85eccbead410f825c19cb0e97e6
Cr-Commit-Position: refs/heads/master@{#14797}

Powered by Google App Engine
This is Rietveld 408576698