Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2447683002: Improves audio logs of native audio layers on Android (Closed)

Created:
4 years, 1 month ago by henrika_webrtc
Modified:
4 years, 1 month ago
Reviewers:
magjed_webrtc
CC:
webrtc-reviews_webrtc.org
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Improves audio logs of native audio layers on Android BUG=webrtc:6592, webrtc:6580 Committed: https://crrev.com/fe90b4176ccb781574c90b845212e6fa39dc133f Cr-Commit-Position: refs/heads/master@{#14798}

Patch Set 1 #

Patch Set 2 : Improves logging of audio info on Android using new APIs in M & N #

Total comments: 10

Patch Set 3 : Feedback from magjed@ #

Patch Set 4 : nits #

Patch Set 5 : now it is perfect #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -23 lines) Patch
M webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioRecord.java View 1 2 3 4 2 chunks +31 lines, -17 lines 0 comments Download
M webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioTrack.java View 1 2 3 7 chunks +56 lines, -6 lines 0 comments Download
M webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioUtils.java View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (6 generated)
henrika_webrtc
This CL is a cleanup of how audio parameters are logged on Android. The style ...
4 years, 1 month ago (2016-10-25 14:36:26 UTC) #4
henrika_webrtc
PTAL
4 years, 1 month ago (2016-10-25 14:36:41 UTC) #5
magjed_webrtc
https://codereview.webrtc.org/2447683002/diff/20001/webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioRecord.java File webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioRecord.java (right): https://codereview.webrtc.org/2447683002/diff/20001/webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioRecord.java#newcode249 webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioRecord.java:249: if (audioRecord.getAudioFormat() != AudioFormat.ENCODING_PCM_16BIT nit: I think it's cleaner ...
4 years, 1 month ago (2016-10-26 12:51:18 UTC) #6
henrika_webrtc
Thanks. PTAL. https://codereview.webrtc.org/2447683002/diff/20001/webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioRecord.java File webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioRecord.java (right): https://codereview.webrtc.org/2447683002/diff/20001/webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioRecord.java#newcode249 webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioRecord.java:249: if (audioRecord.getAudioFormat() != AudioFormat.ENCODING_PCM_16BIT Agree https://codereview.webrtc.org/2447683002/diff/20001/webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioTrack.java File ...
4 years, 1 month ago (2016-10-26 13:19:46 UTC) #7
magjed_webrtc
https://codereview.webrtc.org/2447683002/diff/20001/webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioRecord.java File webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioRecord.java (right): https://codereview.webrtc.org/2447683002/diff/20001/webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioRecord.java#newcode249 webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioRecord.java:249: if (audioRecord.getAudioFormat() != AudioFormat.ENCODING_PCM_16BIT On 2016/10/26 13:19:46, henrika_webrtc wrote: ...
4 years, 1 month ago (2016-10-26 14:35:16 UTC) #8
henrika_webrtc
PTAL https://codereview.webrtc.org/2447683002/diff/20001/webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioRecord.java File webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioRecord.java (right): https://codereview.webrtc.org/2447683002/diff/20001/webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioRecord.java#newcode249 webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioRecord.java:249: if (audioRecord.getAudioFormat() != AudioFormat.ENCODING_PCM_16BIT Sorry. I stopped thinking ...
4 years, 1 month ago (2016-10-26 14:49:10 UTC) #9
magjed_webrtc
lgtm
4 years, 1 month ago (2016-10-26 18:49:12 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2447683002/80001
4 years, 1 month ago (2016-10-27 07:49:53 UTC) #12
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 1 month ago (2016-10-27 08:42:18 UTC) #14
commit-bot: I haz the power
Patchset 5 (id:??) landed as https://crrev.com/fe90b4176ccb781574c90b845212e6fa39dc133f Cr-Commit-Position: refs/heads/master@{#14798}
4 years, 1 month ago (2016-10-27 08:42:24 UTC) #16
henrika_webrtc
4 years ago (2016-12-14 10:10:28 UTC) #17
Message was sent while issue was closed. 
A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.webrtc.org/2577623002/ by henrika@webrtc.org.

The reason for reverting is: Can cause issues on devices that reports bad
current values..

Powered by Google App Engine
This is Rietveld 408576698