Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Issue 2447163003: Decrease threshold for key frame generation. (Closed)

Created:
4 years, 1 month ago by AlexG
Modified:
4 years, 1 month ago
Reviewers:
magjed_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, åsapersson
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Decrease threshold for key frame generation. On some recent Android devices camera switch is completed in 400 ms. Need to adjust key frame generation threshold to ensure HW encoder still generates a key frame after camera switch to workaround video distortions. BUG=b/32238476 Committed: https://crrev.com/489c0d4832c82306b4dfa772bb17e58b6b0991f8 Cr-Commit-Position: refs/heads/master@{#14791}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M webrtc/api/android/jni/androidmediaencoder_jni.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
AlexG
PTAL
4 years, 1 month ago (2016-10-25 23:47:36 UTC) #2
magjed_webrtc
lgtm
4 years, 1 month ago (2016-10-26 12:40:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2447163003/1
4 years, 1 month ago (2016-10-26 17:32:05 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-26 17:53:00 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-10-26 18:21:47 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/489c0d4832c82306b4dfa772bb17e58b6b0991f8
Cr-Commit-Position: refs/heads/master@{#14791}

Powered by Google App Engine
This is Rietveld 408576698