Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issue 2447103002: Move parsing from tests to TestTransport in RTPSenderTests (Closed)

Created:
4 years, 1 month ago by danilchap
Modified:
4 years, 1 month ago
Reviewers:
sprang_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, danilchap, stefan-webrtc, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Move parsing from tests to Transport helper in RTPSenderTests making tests cleaner BUG=webrtc:5565 Committed: https://crrev.com/12ba1867a24eff7480e1983cac890016b204107d Cr-Commit-Position: refs/heads/master@{#14782}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -198 lines) Patch
M webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc View 27 chunks +90 lines, -198 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
danilchap
4 years, 1 month ago (2016-10-25 14:40:30 UTC) #3
sprang_webrtc
lgtm
4 years, 1 month ago (2016-10-26 08:11:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2447103002/1
4 years, 1 month ago (2016-10-26 09:12:55 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-26 09:41:58 UTC) #8
commit-bot: I haz the power
4 years, 1 month ago (2016-10-26 09:42:08 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/12ba1867a24eff7480e1983cac890016b204107d
Cr-Commit-Position: refs/heads/master@{#14782}

Powered by Google App Engine
This is Rietveld 408576698