Fixing flaky DtmfSenderTest by using fake clock.

Fixing flaky DtmfSenderTest by using fake clock.

This test was expecting tones to be sent at specific times, with a 100ms
margin of error, causing slower bots or bots with less precise timing to
fail the test occasionally.

BUG=webrtc:4219, webrtc:5657
Committed: https://crrev.com/e7fc7d5c02038372e8b327baed4cb7931c197f67
Cr-Commit-Position: refs/heads/master@{#14828}

[honghaiz3, 2016-10-28 17:23:25]

honghaiz@webrtc.org changed reviewers:
+ honghaiz@webrtc.org

[honghaiz3, 2016-10-28 17:23:26]

https://codereview.webrtc.org/2447013007/diff/1/webrtc/api/dtmfsender_unittes...
File webrtc/api/dtmfsender_unittest.cc (right):

https://codereview.webrtc.org/2447013007/diff/1/webrtc/api/dtmfsender_unittes...
webrtc/api/dtmfsender_unittest.cc:33: // to each test based on the tones sent,
instead.
Is there a problem if we change it in this CL?

https://codereview.webrtc.org/2447013007/diff/1/webrtc/api/dtmfsender_unittes...
webrtc/api/dtmfsender_unittest.cc:297: WAIT(false, 200);
Change this and another one below to to SIMULATED_WAIT.

[skvlad, 2016-10-28 19:21:43]

skvlad@webrtc.org changed reviewers:
+ skvlad@webrtc.org

[skvlad, 2016-10-28 19:21:44]

lgtm

[Taylor Brandstetter, 2016-10-28 20:31:23]

https://codereview.webrtc.org/2447013007/diff/1/webrtc/api/dtmfsender_unittes...
File webrtc/api/dtmfsender_unittest.cc (right):

https://codereview.webrtc.org/2447013007/diff/1/webrtc/api/dtmfsender_unittes...
webrtc/api/dtmfsender_unittest.cc:33: // to each test based on the tones sent,
instead.
On 2016/10/28 17:23:26, honghaiz3 wrote:
> Is there a problem if we change it in this CL?

It just seemed like more work than necessary at the moment. The goal here is
just to fix the flakiness of the test, not make the test do more than it did
originally.

https://codereview.webrtc.org/2447013007/diff/1/webrtc/api/dtmfsender_unittes...
webrtc/api/dtmfsender_unittest.cc:297: WAIT(false, 200);
On 2016/10/28 17:23:26, honghaiz3 wrote:
> Change this and another one below to to SIMULATED_WAIT. 

Good catch, done.

[Taylor Brandstetter, 2016-10-28 20:31:31]

The CQ bit was checked by deadbeef@webrtc.org

[Taylor Brandstetter, 2016-10-28 20:31:31]

The patchset sent to the CQ was uploaded after l-g-t-m from skvlad@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2447013007/#ps20001 (title:
"Replace WAIT with SIMULATED_WAIT in a couple places.")

[commit-bot: I haz the power, 2016-10-28 20:31:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[honghaiz3, 2016-10-28 20:37:56]

lgtm

[commit-bot: I haz the power, 2016-10-28 20:53:11]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-28 20:53:24]

Description was changed from

==========
Fixing flaky DtmfSenderTest by using fake clock.

This test was expecting tones to be sent at specific times, with a 100ms
margin of error, causing slower bots or bots with less precise timing to
fail the test occasionally.

BUG=webrtc:4219,webrtc:5657
==========

to

==========
Fixing flaky DtmfSenderTest by using fake clock.

This test was expecting tones to be sent at specific times, with a 100ms
margin of error, causing slower bots or bots with less precise timing to
fail the test occasionally.

BUG=webrtc:4219,webrtc:5657

Committed: https://crrev.com/e7fc7d5c02038372e8b327baed4cb7931c197f67
Cr-Commit-Position: refs/heads/master@{#14828}
==========

[commit-bot: I haz the power, 2016-10-28 20:53:25]

Patchset 2 (id:??) landed as
https://crrev.com/e7fc7d5c02038372e8b327baed4cb7931c197f67
Cr-Commit-Position: refs/heads/master@{#14828}