Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 2446733003: Update XServerPixelBuffer to handle errors returned from XGetImage(). (Closed)

Created:
4 years, 1 month ago by Sergey Ulanov
Modified:
4 years, 1 month ago
Reviewers:
GeorgeZ
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Update XServerPixelBuffer to handle errors returned from XGetImage(). XGetImage() may return NULL and XServerPixelBuffer wasn't handling this case properly. BUG=649487 Committed: https://crrev.com/4a18f16c62975e21ab3db9eb7a3812220ee6b3c6 Cr-Commit-Position: refs/heads/master@{#14754}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -5 lines) Patch
M webrtc/modules/desktop_capture/screen_capturer_x11.cc View 2 chunks +7 lines, -1 line 0 comments Download
M webrtc/modules/desktop_capture/window_capturer_x11.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M webrtc/modules/desktop_capture/x11/x_server_pixel_buffer.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/desktop_capture/x11/x_server_pixel_buffer.cc View 3 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Sergey Ulanov
4 years, 1 month ago (2016-10-24 21:04:36 UTC) #2
GeorgeZ
On 2016/10/24 21:04:36, Sergey Ulanov wrote: lgtm
4 years, 1 month ago (2016-10-24 21:35:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2446733003/1
4 years, 1 month ago (2016-10-24 21:38:14 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-24 22:45:51 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-10-24 22:45:57 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4a18f16c62975e21ab3db9eb7a3812220ee6b3c6
Cr-Commit-Position: refs/heads/master@{#14754}

Powered by Google App Engine
This is Rietveld 408576698