Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2446143002: Start using APM directly in WVoMC (not VoEAudioProcessing) (Closed)

Created:
4 years, 1 month ago by the sun
Modified:
4 years, 1 month ago
CC:
webrtc-reviews_webrtc.org, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

- Replace FakeAudioProcessing in WVoE unittest with MockAudioProcessing. - Update MockAudioProcessing to current APM interface. - Replace calls to VoEAudioProcessing::Start/StopAecDump with direct calls on APM. - Add AudioProcessing* in WVoE, get it from VoE, so we can call directly on APM. BUG=webrtc:4690 Committed: https://crrev.com/059fb4480b4bc402c2dd52c04c5028db50802f58 Cr-Commit-Position: refs/heads/master@{#14786}

Patch Set 1 #

Patch Set 2 : fix unit tests #

Patch Set 3 : remove line #

Patch Set 4 : android build error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+358 lines, -491 lines) Patch
M webrtc/media/engine/fakewebrtcvoiceengine.h View 8 chunks +5 lines, -96 lines 0 comments Download
M webrtc/media/engine/webrtcvoiceengine.h View 2 chunks +3 lines, -0 lines 0 comments Download
M webrtc/media/engine/webrtcvoiceengine.cc View 2 8 chunks +18 lines, -21 lines 0 comments Download
M webrtc/media/engine/webrtcvoiceengine_unittest.cc View 1 2 3 116 chunks +204 lines, -164 lines 0 comments Download
M webrtc/modules/audio_processing/agc/agc_manager_direct_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_processing/include/mock_audio_processing.h View 2 chunks +127 lines, -209 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
the sun
peah@ for the APM mock. minyue@ for the rest.
4 years, 1 month ago (2016-10-25 20:09:46 UTC) #3
peah-webrtc
On 2016/10/25 20:09:46, the sun wrote: > peah@ for the APM mock. > minyue@ for ...
4 years, 1 month ago (2016-10-26 05:15:50 UTC) #4
minyue-webrtc
LGTM % the title may better not start with a "-"
4 years, 1 month ago (2016-10-26 09:41:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2446143002/60001
4 years, 1 month ago (2016-10-26 11:31:17 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 1 month ago (2016-10-26 12:12:28 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-10-26 12:12:37 UTC) #11
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/059fb4480b4bc402c2dd52c04c5028db50802f58
Cr-Commit-Position: refs/heads/master@{#14786}

Powered by Google App Engine
This is Rietveld 408576698