Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2445733002: Delete unused features of rtc::FilesystemInterface. (Closed)

Created:
4 years, 1 month ago by nisse-webrtc
Modified:
4 years, 1 month ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Delete unused features of rtc::FilesystemInterface and related classes. Deleted methods: DirectoryIterator::FileSize DirectoryIterator::IsDots DirectoryIterator::OlderThan FilesystemInterface::CleanAppTempFolder FilesystemInterface::CopyFileOrFolder FilesystemInterface::CopyFolder FilesystemInterface::CreatePrivateFile FilesystemInterface::DeleteFileOrFolder FilesystemInterface::GetAppPathname FilesystemInterface::GetCurrentDirectory FilesystemInterface::MoveFileOrFolder FilesystemInterface::MoveFolder Filesystem::CleanAppTempFolder Filesystem::CopyFolder Filesystem::CreatePrivateFile Filesystem::CreateUniqueFile Filesystem::DeleteEmptyFolder Filesystem::GetAppPathname Filesystem::GetCurrentDirectory Filesystem::MoveFolder BUG=webrtc:6424 Committed: https://crrev.com/da35f3e3ce660785503197c59e7b20524744b73f Cr-Commit-Position: refs/heads/master@{#14800}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -528 lines) Patch
M webrtc/base/fileutils.h View 11 chunks +0 lines, -106 lines 0 comments Download
M webrtc/base/fileutils.cc View 3 chunks +0 lines, -114 lines 0 comments Download
M webrtc/base/fileutils_mock.h View 4 chunks +1 line, -16 lines 0 comments Download
M webrtc/base/fileutils_unittest.cc View 2 chunks +0 lines, -34 lines 0 comments Download
M webrtc/base/unixfilesystem.h View 4 chunks +0 lines, -11 lines 0 comments Download
M webrtc/base/unixfilesystem.cc View 4 chunks +0 lines, -66 lines 0 comments Download
M webrtc/base/win32filesystem.h View 4 chunks +4 lines, -14 lines 0 comments Download
M webrtc/base/win32filesystem.cc View 3 chunks +0 lines, -167 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
nisse-webrtc
Please take a look. These are unused, as far as I've been able to find.
4 years, 1 month ago (2016-10-25 08:30:35 UTC) #3
kjellander_webrtc
lgtm nit: I'd prefer a sorted, one-per-line list of function names in the CL description.
4 years, 1 month ago (2016-10-25 08:44:34 UTC) #4
kjellander_webrtc
On 2016/10/25 08:44:34, kjellander_webrtc wrote: > lgtm > > nit: I'd prefer a sorted, one-per-line ...
4 years, 1 month ago (2016-10-25 08:44:51 UTC) #5
nisse-webrtc
On 2016/10/25 08:44:34, kjellander_webrtc wrote: > lgtm > > nit: I'd prefer a sorted, one-per-line ...
4 years, 1 month ago (2016-10-25 09:53:54 UTC) #7
pthatcher1
lgtm
4 years, 1 month ago (2016-10-26 18:46:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2445733002/1
4 years, 1 month ago (2016-10-27 06:31:15 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_x64_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_x64_rel/builds/18997)
4 years, 1 month ago (2016-10-27 08:35:32 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2445733002/1
4 years, 1 month ago (2016-10-27 11:36:22 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-27 11:44:42 UTC) #16
commit-bot: I haz the power
4 years, 1 month ago (2016-10-27 11:44:55 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/da35f3e3ce660785503197c59e7b20524744b73f
Cr-Commit-Position: refs/heads/master@{#14800}

Powered by Google App Engine
This is Rietveld 408576698