Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Issue 2445343003: PrintTo functions for RTCStats added in rtcstatscollector_unittest.cc (Closed)

Created:
4 years, 1 month ago by hbos
Modified:
4 years, 1 month ago
Reviewers:
hta-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

PrintTo functions for RTCStats added in rtcstatscollector_unittest.cc Future test code will do stuff like EXPECT_EQ(report, expected_report). They're all defined in the unittest because it and stats' operator== is only used for testing. See https://cs.chromium.org/chromium/src/testing/gtest/include/gtest/gtest-printers.h?sq=package:chromium&dr=C&rcl=1477394469&l=707 BUG=chromium:627816 Committed: https://crrev.com/da389e351878d046f9eb6f305f04537774375f27 Cr-Commit-Position: refs/heads/master@{#14779}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -0 lines) Patch
M webrtc/api/rtcstatscollector_unittest.cc View 2 chunks +30 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
hbos
Please take a look, hta
4 years, 1 month ago (2016-10-25 17:19:28 UTC) #2
hta-webrtc
lgtm
4 years, 1 month ago (2016-10-25 17:21:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2445343003/1
4 years, 1 month ago (2016-10-25 17:21:39 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-25 17:55:13 UTC) #8
commit-bot: I haz the power
4 years, 1 month ago (2016-10-25 18:22:59 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/da389e351878d046f9eb6f305f04537774375f27
Cr-Commit-Position: refs/heads/master@{#14779}

Powered by Google App Engine
This is Rietveld 408576698