Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2444853002:
Roll chromium_revision 1362287708..9b5bb47fa0 (426760:426837) + roll Android SDK to N (Closed)
|
Created:
4 years, 2 months ago by ehmaldonado Modified:
4 years, 1 month ago CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionRoll chromium_revision 1362287708..9b5bb47fa0 (426760:426837) + roll Android SDK to N
This roll brings in the Android N SDK.
Add lint suppressions for Android to suppress errors caused by the new lint rules.
Change log: https://chromium.googlesource.com/chromium/src/+log/1362287708..9b5bb47fa0
Full diff: https://chromium.googlesource.com/chromium/src/+/1362287708..9b5bb47fa0
Changed dependencies:
* src/third_party/libsrtp: https://chromium.googlesource.com/chromium/deps/libsrtp.git/+log/b17c065a8a..71692eaab2
DEPS diff: https://chromium.googlesource.com/chromium/src/+/1362287708..9b5bb47fa0/DEPS
No update to Clang.
TBR=
NOTRY=True
BUG=webrtc:6534
Committed: https://crrev.com/d312713e61de5a63103ee7026a2dacb983d91858
Cr-Commit-Position: refs/heads/master@{#14746}
Patch Set 1 #Messages
Total messages: 18 (11 generated)
Description was changed from ========== Add lint suppressions for Android. Roll chromium_revision 1362287708..9b5bb47fa0 (426760:426837) Change log: https://chromium.googlesource.com/chromium/src/+log/1362287708..9b5bb47fa0 Full diff: https://chromium.googlesource.com/chromium/src/+/1362287708..9b5bb47fa0 Changed dependencies: * src/third_party/libsrtp: https://chromium.googlesource.com/chromium/deps/libsrtp.git/+log/b17c065a8a..... DEPS diff: https://chromium.googlesource.com/chromium/src/+/1362287708..9b5bb47fa0/DEPS No update to Clang. TBR= BUG=None BUG= ========== to ========== Add lint suppressions for Android. Roll chromium_revision 1362287708..9b5bb47fa0 (426760:426837) Change log: https://chromium.googlesource.com/chromium/src/+log/1362287708..9b5bb47fa0 Full diff: https://chromium.googlesource.com/chromium/src/+/1362287708..9b5bb47fa0 Changed dependencies: * src/third_party/libsrtp: https://chromium.googlesource.com/chromium/deps/libsrtp.git/+log/b17c065a8a..... DEPS diff: https://chromium.googlesource.com/chromium/src/+/1362287708..9b5bb47fa0/DEPS No update to Clang. TBR= BUG=None ==========
ehmaldonado@webrtc.org changed reviewers: + ehmaldonado@webrtc.org, kjellander@webrtc.org
Huh, this wasn't uploaded with my WebRTC account. In any case, should I file a bug for these suppressions?
Description was changed from ========== Add lint suppressions for Android. Roll chromium_revision 1362287708..9b5bb47fa0 (426760:426837) Change log: https://chromium.googlesource.com/chromium/src/+log/1362287708..9b5bb47fa0 Full diff: https://chromium.googlesource.com/chromium/src/+/1362287708..9b5bb47fa0 Changed dependencies: * src/third_party/libsrtp: https://chromium.googlesource.com/chromium/deps/libsrtp.git/+log/b17c065a8a..... DEPS diff: https://chromium.googlesource.com/chromium/src/+/1362287708..9b5bb47fa0/DEPS No update to Clang. TBR= BUG=None ========== to ========== Roll chromium_revision 1362287708..9b5bb47fa0 (426760:426837) Add lint suppressions for Android. Change log: https://chromium.googlesource.com/chromium/src/+log/1362287708..9b5bb47fa0 Full diff: https://chromium.googlesource.com/chromium/src/+/1362287708..9b5bb47fa0 Changed dependencies: * src/third_party/libsrtp: https://chromium.googlesource.com/chromium/deps/libsrtp.git/+log/b17c065a8a..... DEPS diff: https://chromium.googlesource.com/chromium/src/+/1362287708..9b5bb47fa0/DEPS No update to Clang. TBR= BUG=None ==========
Description was changed from ========== Roll chromium_revision 1362287708..9b5bb47fa0 (426760:426837) Add lint suppressions for Android. Change log: https://chromium.googlesource.com/chromium/src/+log/1362287708..9b5bb47fa0 Full diff: https://chromium.googlesource.com/chromium/src/+/1362287708..9b5bb47fa0 Changed dependencies: * src/third_party/libsrtp: https://chromium.googlesource.com/chromium/deps/libsrtp.git/+log/b17c065a8a..... DEPS diff: https://chromium.googlesource.com/chromium/src/+/1362287708..9b5bb47fa0/DEPS No update to Clang. TBR= BUG=None ========== to ========== Roll chromium_revision 1362287708..9b5bb47fa0 (426760:426837) This roll brings in the Android N SDK. Add lint suppressions for Android to suppress errors caused by the new lint rules. Change log: https://chromium.googlesource.com/chromium/src/+log/1362287708..9b5bb47fa0 Full diff: https://chromium.googlesource.com/chromium/src/+/1362287708..9b5bb47fa0 Changed dependencies: * src/third_party/libsrtp: https://chromium.googlesource.com/chromium/deps/libsrtp.git/+log/b17c065a8a..... DEPS diff: https://chromium.googlesource.com/chromium/src/+/1362287708..9b5bb47fa0/DEPS No update to Clang. TBR= BUG=None ==========
On 2016/10/24 12:35:57, ehmaldonado_webrtc wrote: > Huh, this wasn't uploaded with my WebRTC account. > In any case, should I file a bug for these suppressions? I already filed https://bugs.chromium.org/p/webrtc/issues/detail?id=6534 before. That's it right? lgtm
Description was changed from ========== Roll chromium_revision 1362287708..9b5bb47fa0 (426760:426837) This roll brings in the Android N SDK. Add lint suppressions for Android to suppress errors caused by the new lint rules. Change log: https://chromium.googlesource.com/chromium/src/+log/1362287708..9b5bb47fa0 Full diff: https://chromium.googlesource.com/chromium/src/+/1362287708..9b5bb47fa0 Changed dependencies: * src/third_party/libsrtp: https://chromium.googlesource.com/chromium/deps/libsrtp.git/+log/b17c065a8a..... DEPS diff: https://chromium.googlesource.com/chromium/src/+/1362287708..9b5bb47fa0/DEPS No update to Clang. TBR= BUG=None ========== to ========== Roll chromium_revision 1362287708..9b5bb47fa0 (426760:426837) This roll brings in the Android N SDK. Add lint suppressions for Android to suppress errors caused by the new lint rules. Change log: https://chromium.googlesource.com/chromium/src/+log/1362287708..9b5bb47fa0 Full diff: https://chromium.googlesource.com/chromium/src/+/1362287708..9b5bb47fa0 Changed dependencies: * src/third_party/libsrtp: https://chromium.googlesource.com/chromium/deps/libsrtp.git/+log/b17c065a8a..... DEPS diff: https://chromium.googlesource.com/chromium/src/+/1362287708..9b5bb47fa0/DEPS No update to Clang. TBR= BUG=WebRTC:6534 ==========
Description was changed from ========== Roll chromium_revision 1362287708..9b5bb47fa0 (426760:426837) This roll brings in the Android N SDK. Add lint suppressions for Android to suppress errors caused by the new lint rules. Change log: https://chromium.googlesource.com/chromium/src/+log/1362287708..9b5bb47fa0 Full diff: https://chromium.googlesource.com/chromium/src/+/1362287708..9b5bb47fa0 Changed dependencies: * src/third_party/libsrtp: https://chromium.googlesource.com/chromium/deps/libsrtp.git/+log/b17c065a8a..... DEPS diff: https://chromium.googlesource.com/chromium/src/+/1362287708..9b5bb47fa0/DEPS No update to Clang. TBR= BUG=WebRTC:6534 ========== to ========== Roll chromium_revision 1362287708..9b5bb47fa0 (426760:426837) This roll brings in the Android N SDK. Add lint suppressions for Android to suppress errors caused by the new lint rules. Change log: https://chromium.googlesource.com/chromium/src/+log/1362287708..9b5bb47fa0 Full diff: https://chromium.googlesource.com/chromium/src/+/1362287708..9b5bb47fa0 Changed dependencies: * src/third_party/libsrtp: https://chromium.googlesource.com/chromium/deps/libsrtp.git/+log/b17c065a8a..... DEPS diff: https://chromium.googlesource.com/chromium/src/+/1362287708..9b5bb47fa0/DEPS No update to Clang. TBR= BUG=webrtc:6534 ==========
Description was changed from ========== Roll chromium_revision 1362287708..9b5bb47fa0 (426760:426837) This roll brings in the Android N SDK. Add lint suppressions for Android to suppress errors caused by the new lint rules. Change log: https://chromium.googlesource.com/chromium/src/+log/1362287708..9b5bb47fa0 Full diff: https://chromium.googlesource.com/chromium/src/+/1362287708..9b5bb47fa0 Changed dependencies: * src/third_party/libsrtp: https://chromium.googlesource.com/chromium/deps/libsrtp.git/+log/b17c065a8a..... DEPS diff: https://chromium.googlesource.com/chromium/src/+/1362287708..9b5bb47fa0/DEPS No update to Clang. TBR= BUG=webrtc:6534 ========== to ========== Roll chromium_revision 1362287708..9b5bb47fa0 (426760:426837) + roll Android SDK to N This roll brings in the Android N SDK. Add lint suppressions for Android to suppress errors caused by the new lint rules. Change log: https://chromium.googlesource.com/chromium/src/+log/1362287708..9b5bb47fa0 Full diff: https://chromium.googlesource.com/chromium/src/+/1362287708..9b5bb47fa0 Changed dependencies: * src/third_party/libsrtp: https://chromium.googlesource.com/chromium/deps/libsrtp.git/+log/b17c065a8a..... DEPS diff: https://chromium.googlesource.com/chromium/src/+/1362287708..9b5bb47fa0/DEPS No update to Clang. TBR= BUG=webrtc:6534 ==========
On 2016/10/24 12:51:52, kjellander_webrtc wrote: > On 2016/10/24 12:35:57, ehmaldonado_webrtc wrote: > > Huh, this wasn't uploaded with my WebRTC account. > > In any case, should I file a bug for these suppressions? > > I already filed https://bugs.chromium.org/p/webrtc/issues/detail?id=6534 before. > That's it right? > > lgtm (forgot to mention I changed the CL title and description a little)
Description was changed from ========== Roll chromium_revision 1362287708..9b5bb47fa0 (426760:426837) + roll Android SDK to N This roll brings in the Android N SDK. Add lint suppressions for Android to suppress errors caused by the new lint rules. Change log: https://chromium.googlesource.com/chromium/src/+log/1362287708..9b5bb47fa0 Full diff: https://chromium.googlesource.com/chromium/src/+/1362287708..9b5bb47fa0 Changed dependencies: * src/third_party/libsrtp: https://chromium.googlesource.com/chromium/deps/libsrtp.git/+log/b17c065a8a..... DEPS diff: https://chromium.googlesource.com/chromium/src/+/1362287708..9b5bb47fa0/DEPS No update to Clang. TBR= BUG=webrtc:6534 ========== to ========== Roll chromium_revision 1362287708..9b5bb47fa0 (426760:426837) + roll Android SDK to N This roll brings in the Android N SDK. Add lint suppressions for Android to suppress errors caused by the new lint rules. Change log: https://chromium.googlesource.com/chromium/src/+log/1362287708..9b5bb47fa0 Full diff: https://chromium.googlesource.com/chromium/src/+/1362287708..9b5bb47fa0 Changed dependencies: * src/third_party/libsrtp: https://chromium.googlesource.com/chromium/deps/libsrtp.git/+log/b17c065a8a..... DEPS diff: https://chromium.googlesource.com/chromium/src/+/1362287708..9b5bb47fa0/DEPS No update to Clang. TBR= NOTRY=True BUG=webrtc:6534 ==========
The CQ bit was checked by ehmaldonado@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Message was sent while issue was closed.
Description was changed from ========== Roll chromium_revision 1362287708..9b5bb47fa0 (426760:426837) + roll Android SDK to N This roll brings in the Android N SDK. Add lint suppressions for Android to suppress errors caused by the new lint rules. Change log: https://chromium.googlesource.com/chromium/src/+log/1362287708..9b5bb47fa0 Full diff: https://chromium.googlesource.com/chromium/src/+/1362287708..9b5bb47fa0 Changed dependencies: * src/third_party/libsrtp: https://chromium.googlesource.com/chromium/deps/libsrtp.git/+log/b17c065a8a..... DEPS diff: https://chromium.googlesource.com/chromium/src/+/1362287708..9b5bb47fa0/DEPS No update to Clang. TBR= NOTRY=True BUG=webrtc:6534 ========== to ========== Roll chromium_revision 1362287708..9b5bb47fa0 (426760:426837) + roll Android SDK to N This roll brings in the Android N SDK. Add lint suppressions for Android to suppress errors caused by the new lint rules. Change log: https://chromium.googlesource.com/chromium/src/+log/1362287708..9b5bb47fa0 Full diff: https://chromium.googlesource.com/chromium/src/+/1362287708..9b5bb47fa0 Changed dependencies: * src/third_party/libsrtp: https://chromium.googlesource.com/chromium/deps/libsrtp.git/+log/b17c065a8a..... DEPS diff: https://chromium.googlesource.com/chromium/src/+/1362287708..9b5bb47fa0/DEPS No update to Clang. TBR= NOTRY=True BUG=webrtc:6534 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Roll chromium_revision 1362287708..9b5bb47fa0 (426760:426837) + roll Android SDK to N This roll brings in the Android N SDK. Add lint suppressions for Android to suppress errors caused by the new lint rules. Change log: https://chromium.googlesource.com/chromium/src/+log/1362287708..9b5bb47fa0 Full diff: https://chromium.googlesource.com/chromium/src/+/1362287708..9b5bb47fa0 Changed dependencies: * src/third_party/libsrtp: https://chromium.googlesource.com/chromium/deps/libsrtp.git/+log/b17c065a8a..... DEPS diff: https://chromium.googlesource.com/chromium/src/+/1362287708..9b5bb47fa0/DEPS No update to Clang. TBR= NOTRY=True BUG=webrtc:6534 ========== to ========== Roll chromium_revision 1362287708..9b5bb47fa0 (426760:426837) + roll Android SDK to N This roll brings in the Android N SDK. Add lint suppressions for Android to suppress errors caused by the new lint rules. Change log: https://chromium.googlesource.com/chromium/src/+log/1362287708..9b5bb47fa0 Full diff: https://chromium.googlesource.com/chromium/src/+/1362287708..9b5bb47fa0 Changed dependencies: * src/third_party/libsrtp: https://chromium.googlesource.com/chromium/deps/libsrtp.git/+log/b17c065a8a..... DEPS diff: https://chromium.googlesource.com/chromium/src/+/1362287708..9b5bb47fa0/DEPS No update to Clang. TBR= NOTRY=True BUG=webrtc:6534 Committed: https://crrev.com/d312713e61de5a63103ee7026a2dacb983d91858 Cr-Commit-Position: refs/heads/master@{#14746} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/d312713e61de5a63103ee7026a2dacb983d91858 Cr-Commit-Position: refs/heads/master@{#14746} |
