Move ScreenCapturer 'real' tests out of screen_capturer_unittest.cc.

Move ScreenCapturer 'real' tests out of screen_capturer_unittest.cc.

This is a trivial change, I just cutted and pasted part of the code in
screen_capturer_unittest.cc to screen_capturer_integration_test.cc, removed
DISABLED_ prefixes, and updated build file.

BUG=webrtc:6366
Committed: https://crrev.com/6be0a657c563acfb3f9b2502c4453d7ba46ef0d1
Cr-Commit-Position: refs/heads/master@{#14806}

[Hzj_jie, 2016-10-22 00:01:34]

Patchset #2 (id:20001) has been deleted

[Hzj_jie, 2016-10-22 00:01:50]

Patchset #1 (id:1) has been deleted

[Hzj_jie, 2016-10-22 00:06:07]

Patchset #1 (id:40001) has been deleted

[Hzj_jie, 2016-10-22 00:15:03]

Patchset #1 (id:60001) has been deleted

[Hzj_jie, 2016-10-23 21:28:25]

Description was changed from

==========
Move ScreenCapturer 'real' tests out of screen_capturer_unittest.cc.

BUG=https://bugs.chromium.org/p/webrtc/issues/detail?id=6366
==========

to

==========
Move ScreenCapturer 'real' tests out of screen_capturer_unittest.cc.

This is a trivial change, I just cutted and pasted part of the code in
screen_capturer_unittest.cc to screen_capturer_integration_test.cc, removed
DISABLED_ prefixes, and updated build file.

I have executed these tests on asan trybots for several times, and no flaky
behavior detected. It looks good to go.

Henrik, do we have a Windows 8 or upper trybot. Part of the tests require
Windows 8 or upper. Though I have tested them on my machine, it would be great
if we have an automatical way to do so.

BUG=https://bugs.chromium.org/p/webrtc/issues/detail?id=6366
==========

[Hzj_jie, 2016-10-23 21:28:25]

zijiehe@chromium.org changed reviewers:
+ kjellander@webrtc.org, sergeyu@chromium.org

[Hzj_jie, 2016-10-23 21:46:15]

Description was changed from

==========
Move ScreenCapturer 'real' tests out of screen_capturer_unittest.cc.

This is a trivial change, I just cutted and pasted part of the code in
screen_capturer_unittest.cc to screen_capturer_integration_test.cc, removed
DISABLED_ prefixes, and updated build file.

I have executed these tests on asan trybots for several times, and no flaky
behavior detected. It looks good to go.

Henrik, do we have a Windows 8 or upper trybot. Part of the tests require
Windows 8 or upper. Though I have tested them on my machine, it would be great
if we have an automatical way to do so.

BUG=https://bugs.chromium.org/p/webrtc/issues/detail?id=6366
==========

to

==========
Move ScreenCapturer 'real' tests out of screen_capturer_unittest.cc.

This is a trivial change, I just cutted and pasted part of the code in
screen_capturer_unittest.cc to screen_capturer_integration_test.cc, removed
DISABLED_ prefixes, and updated build file.

I have executed these tests on asan trybots for several times, and no flaky
behavior detected. It looks good to go.

Henrik, do we have a Windows 8 or upper trybot. Some of the tests require
Windows 8 or upper. Though I have tested them on my machine, it would be great
if we have an automatical way to do so.

BUG=https://bugs.chromium.org/p/webrtc/issues/detail?id=6366
==========

[kjellander_webrtc, 2016-10-24 07:30:20]

I'm quoting from the CL description (these lines don't belong there, rather in
the review messages, please remove them):

> I have executed these tests on asan trybots for several times, and no flaky
> behavior detected. It looks good to go.

> Henrik, do we have a Windows 8 or upper trybot. Some of the tests require
> Windows 8 or upper. Though I have tested them on my machine, it would be great
> if we have an automatical way to do so.

We currently don't have any win8 bots among our trybots. I requested Win8 and
Win10 machines in https://bugs.chromium.org/p/chromium/issues/detail?id=658652
so we can set this up, since it makes sense we have better coverage in this area
(all our trybots are Win7 today).

Finally, please change:
BUG=https://bugs.chromium.org/p/webrtc/issues/detail?id=6366
to
BUG=webrtc:6366

https://codereview.chromium.org/2444583002/diff/80001/webrtc/modules/BUILD.gn
File webrtc/modules/BUILD.gn (right):

https://codereview.chromium.org/2444583002/diff/80001/webrtc/modules/BUILD.gn...
webrtc/modules/BUILD.gn:102: "desktop_capture/rgba_color.cc",
Please, can we avoid adding duplicated code here. I suggest moving 
desktop_capture/rgba_color.*
desktop_capture/screen_drawer*
into a new source_set target 'desktop_capture_test_tools' in
webrtc/modules/desktop_capture/BUILD.gn

Then add a dependency on it here and in modules_unittests:
https://cs.chromium.org/chromium/src/third_party/webrtc/modules/BUILD.gn?rcl=...

[Hzj_jie, 2016-10-24 18:37:37]

Description was changed from

==========
Move ScreenCapturer 'real' tests out of screen_capturer_unittest.cc.

This is a trivial change, I just cutted and pasted part of the code in
screen_capturer_unittest.cc to screen_capturer_integration_test.cc, removed
DISABLED_ prefixes, and updated build file.

I have executed these tests on asan trybots for several times, and no flaky
behavior detected. It looks good to go.

Henrik, do we have a Windows 8 or upper trybot. Some of the tests require
Windows 8 or upper. Though I have tested them on my machine, it would be great
if we have an automatical way to do so.

BUG=https://bugs.chromium.org/p/webrtc/issues/detail?id=6366
==========

to

==========
Move ScreenCapturer 'real' tests out of screen_capturer_unittest.cc.

This is a trivial change, I just cutted and pasted part of the code in
screen_capturer_unittest.cc to screen_capturer_integration_test.cc, removed
DISABLED_ prefixes, and updated build file.

I have executed these tests on asan trybots for several times, and no flaky
behavior detected. It looks good to go.

BUG=https://bugs.chromium.org/p/webrtc/issues/detail?id=6366
==========

[Hzj_jie, 2016-10-24 18:37:53]

Description was changed from

==========
Move ScreenCapturer 'real' tests out of screen_capturer_unittest.cc.

This is a trivial change, I just cutted and pasted part of the code in
screen_capturer_unittest.cc to screen_capturer_integration_test.cc, removed
DISABLED_ prefixes, and updated build file.

I have executed these tests on asan trybots for several times, and no flaky
behavior detected. It looks good to go.

BUG=https://bugs.chromium.org/p/webrtc/issues/detail?id=6366
==========

to

==========
Move ScreenCapturer 'real' tests out of screen_capturer_unittest.cc.

This is a trivial change, I just cutted and pasted part of the code in
screen_capturer_unittest.cc to screen_capturer_integration_test.cc, removed
DISABLED_ prefixes, and updated build file.

BUG=https://bugs.chromium.org/p/webrtc/issues/detail?id=6366
==========

[Hzj_jie, 2016-10-24 18:38:20]

Description was changed from

==========
Move ScreenCapturer 'real' tests out of screen_capturer_unittest.cc.

This is a trivial change, I just cutted and pasted part of the code in
screen_capturer_unittest.cc to screen_capturer_integration_test.cc, removed
DISABLED_ prefixes, and updated build file.

BUG=https://bugs.chromium.org/p/webrtc/issues/detail?id=6366
==========

to

==========
Move ScreenCapturer 'real' tests out of screen_capturer_unittest.cc.

This is a trivial change, I just cutted and pasted part of the code in
screen_capturer_unittest.cc to screen_capturer_integration_test.cc, removed
DISABLED_ prefixes, and updated build file.

BUG=webrtc:6366
==========

[Hzj_jie, 2016-10-24 20:50:54]

https://codereview.chromium.org/2444583002/diff/80001/webrtc/modules/BUILD.gn
File webrtc/modules/BUILD.gn (right):

https://codereview.chromium.org/2444583002/diff/80001/webrtc/modules/BUILD.gn...
webrtc/modules/BUILD.gn:102: "desktop_capture/rgba_color.cc",
On 2016/10/24 07:30:20, kjellander_webrtc wrote:
> Please, can we avoid adding duplicated code here. I suggest moving 
> desktop_capture/rgba_color.*
> desktop_capture/screen_drawer*
> into a new source_set target 'desktop_capture_test_tools' in
> webrtc/modules/desktop_capture/BUILD.gn
> 
> Then add a dependency on it here and in modules_unittests:
>
https://cs.chromium.org/chromium/src/third_party/webrtc/modules/BUILD.gn?rcl=...
> 
> 

Done.

[kjellander_webrtc, 2016-10-25 07:01:48]

https://codereview.webrtc.org/2444583002/diff/80001/webrtc/modules/BUILD.gn
File webrtc/modules/BUILD.gn (right):

https://codereview.webrtc.org/2444583002/diff/80001/webrtc/modules/BUILD.gn#n...
webrtc/modules/BUILD.gn:102: "desktop_capture/rgba_color.cc",
On 2016/10/24 20:50:54, Hzj_jie wrote:
> On 2016/10/24 07:30:20, kjellander_webrtc wrote:
> > Please, can we avoid adding duplicated code here. I suggest moving 
> > desktop_capture/rgba_color.*
> > desktop_capture/screen_drawer*
> > into a new source_set target 'desktop_capture_test_tools' in
> > webrtc/modules/desktop_capture/BUILD.gn
> > 
> > Then add a dependency on it here and in modules_unittests:
> >
>
https://cs.chromium.org/chromium/src/third_party/webrtc/modules/BUILD.gn?rcl=...
> > 
> > 
> 
> Done.

Please move the target into webrtc/modules/desktop_capture/BUILD.gn
Having it in webrtc/modules/BUILD.gn doesn't make sense.

[kjellander_webrtc, 2016-10-25 19:08:41]

lgtm with my comment addressed.

https://codereview.webrtc.org/2444583002/diff/120001/webrtc/modules/desktop_c...
File webrtc/modules/desktop_capture/BUILD.gn (right):

https://codereview.webrtc.org/2444583002/diff/120001/webrtc/modules/desktop_c...
webrtc/modules/desktop_capture/BUILD.gn:34: public_deps = [
please add
testonly = true
to this target, and put it inside a "if (rtc_include_tests)" condition (see
other test related targets).

[Hzj_jie, 2016-10-25 19:41:47]

https://codereview.webrtc.org/2444583002/diff/120001/webrtc/modules/desktop_c...
File webrtc/modules/desktop_capture/BUILD.gn (right):

https://codereview.webrtc.org/2444583002/diff/120001/webrtc/modules/desktop_c...
webrtc/modules/desktop_capture/BUILD.gn:34: public_deps = [
On 2016/10/25 19:08:41, kjellander_webrtc wrote:
> please add
> testonly = true
> to this target, and put it inside a "if (rtc_include_tests)" condition (see
> other test related targets).

Done.

[Hzj_jie, 2016-10-25 19:42:35]

Thank you Henrik for the review. Go ahead to submit.

[Hzj_jie, 2016-10-25 19:44:06]

The CQ bit was checked by zijiehe@chromium.org

[Hzj_jie, 2016-10-25 19:44:06]

The patchset sent to the CQ was uploaded after l-g-t-m from
kjellander@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2444583002/#ps140001 (title:
"Resolve review comments")

[commit-bot: I haz the power, 2016-10-25 19:44:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-10-25 19:47:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-25 19:47:01]

Try jobs failed on following builders:
  presubmit on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/9546)

[Hzj_jie, 2016-10-25 19:47:46]

Sergey, would you mind to have a look at this change?

[Sergey Ulanov, 2016-10-27 22:45:08]

lgtm

[Hzj_jie, 2016-10-27 23:16:27]

The CQ bit was checked by zijiehe@chromium.org

[commit-bot: I haz the power, 2016-10-27 23:16:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-10-27 23:50:38]

Description was changed from

==========
Move ScreenCapturer 'real' tests out of screen_capturer_unittest.cc.

This is a trivial change, I just cutted and pasted part of the code in
screen_capturer_unittest.cc to screen_capturer_integration_test.cc, removed
DISABLED_ prefixes, and updated build file.

BUG=webrtc:6366
==========

to

==========
Move ScreenCapturer 'real' tests out of screen_capturer_unittest.cc.

This is a trivial change, I just cutted and pasted part of the code in
screen_capturer_unittest.cc to screen_capturer_integration_test.cc, removed
DISABLED_ prefixes, and updated build file.

BUG=webrtc:6366
==========

[commit-bot: I haz the power, 2016-10-27 23:50:39]

Committed patchset #4 (id:140001)

[commit-bot: I haz the power, 2016-10-27 23:50:50]

Description was changed from

==========
Move ScreenCapturer 'real' tests out of screen_capturer_unittest.cc.

This is a trivial change, I just cutted and pasted part of the code in
screen_capturer_unittest.cc to screen_capturer_integration_test.cc, removed
DISABLED_ prefixes, and updated build file.

BUG=webrtc:6366
==========

to

==========
Move ScreenCapturer 'real' tests out of screen_capturer_unittest.cc.

This is a trivial change, I just cutted and pasted part of the code in
screen_capturer_unittest.cc to screen_capturer_integration_test.cc, removed
DISABLED_ prefixes, and updated build file.

BUG=webrtc:6366

Committed: https://crrev.com/6be0a657c563acfb3f9b2502c4453d7ba46ef0d1
Cr-Commit-Position: refs/heads/master@{#14806}
==========

[commit-bot: I haz the power, 2016-10-27 23:50:51]

Patchset 4 (id:??) landed as
https://crrev.com/6be0a657c563acfb3f9b2502c4453d7ba46ef0d1
Cr-Commit-Position: refs/heads/master@{#14806}